This repository was archived by the owner on Nov 30, 2025. It is now read-only.
316 exam bank fix term name of pre 1999 exams#318
Merged
sai3000pro merged 3 commits intomainfrom Jan 30, 2025
Merged
Conversation
some-molasses
approved these changes
Jan 29, 2025
Member
some-molasses
left a comment
There was a problem hiding this comment.
this looks good! - if you wanted to add to it, there's now a lot of logic here involving the Waterloo API that we could delete and replace with your function. if not, we can make a later issue for it and pass it off to someone else!
Contributor
Author
|
Awesome! It looks like there is a lot of code that I would have to go through and understand for the redundant logic - I'd be happy to merge this for now and potentially create a new issue for it and see what I can do later this week. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This issue seems to have been resolved with the new function I have added - titled convertTermCodeToTermName in term-name-controller.ts!
The one thing that came up during testing was that the term code 1071 was mapped to Winter 2007 - could this be confirmed to be correct or not? Since the exam that I downloaded off of the MathSoc website (amath-231-1071-final.pdf) seemed to be for Fall 2003.
The other mappings seemed to work fine. The format that I believed to be correct and implemented was as follows