Skip to content
This repository was archived by the owner on Nov 30, 2025. It is now read-only.

316 exam bank fix term name of pre 1999 exams#318

Merged
sai3000pro merged 3 commits intomainfrom
316-exam-bank-fix-term-name-of-pre-1999-exams
Jan 30, 2025
Merged

316 exam bank fix term name of pre 1999 exams#318
sai3000pro merged 3 commits intomainfrom
316-exam-bank-fix-term-name-of-pre-1999-exams

Conversation

@sai3000pro
Copy link
Contributor

This issue seems to have been resolved with the new function I have added - titled convertTermCodeToTermName in term-name-controller.ts!

The one thing that came up during testing was that the term code 1071 was mapped to Winter 2007 - could this be confirmed to be correct or not? Since the exam that I downloaded off of the MathSoc website (amath-231-1071-final.pdf) seemed to be for Fall 2003.

The other mappings seemed to work fine. The format that I believed to be correct and implemented was as follows

  1. termCodes are either in the format of abcd or bcd.
  2. assuming that a term code that starts with "2" i.e: 2bcd is a year in 2100
  3. bc refers to the year XXbc
  4. d refers to the month (and correspondingly, the term) - 1 means winter, 5 means spring, 9 means fall.

@sai3000pro sai3000pro linked an issue Jan 29, 2025 that may be closed by this pull request
Copy link
Member

@some-molasses some-molasses left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this looks good! - if you wanted to add to it, there's now a lot of logic here involving the Waterloo API that we could delete and replace with your function. if not, we can make a later issue for it and pass it off to someone else!

@sai3000pro
Copy link
Contributor Author

sai3000pro commented Jan 30, 2025

Awesome! It looks like there is a lot of code that I would have to go through and understand for the redundant logic - I'd be happy to merge this for now and potentially create a new issue for it and see what I can do later this week.

@sai3000pro sai3000pro merged commit 89fe29b into main Jan 30, 2025
3 checks passed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Exam bank: Fix term name of pre-1999 exams

2 participants