Revise Import, Export, ImportString, and ExportString#1825
Merged
Conversation
Member
Author
|
Handling Import*, Export* needs a major revision. Watch this space... |
rocky
changed the title
Import, Export, ImportString, and ExportString
Member
Author
|
@mmatera, there are still some hard-coded tables that can be reduced. But this is already a heavy-enough lift. Future reduction will come after the PR clears. |
mmatera
approved these changes
May 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use the PyPI package
python_mimeinFileFormat. This does a better job than what we have now.Pull out internal Import/Export methods and evaluation code under
mathics.eval.files_io. DRY this.Remove cut-and-paste copy (in
mathics.builtin.pymimesniffer), an early Python Package to detect MIME types, which included its embedded unittest code insidemathics.builtin. pymimesniffer.Remove some (but not all yet) MIME translation tables and instead rely on lists in
python_mime.We now detect ZIP files stored with a "mx" extension. This is the kind of file that seems to be created when running
<< https://paclets.github.io/PacletServer/Install.wl