Skip to content

Build helper libraries with position-independent code if BUILD_SHARED_LIBS is set. #144

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
alexrp wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Build helper libraries with position-independent code if BUILD_SHARED_LIBS is set. #144

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions corec/corec/helpers/zlib/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,9 @@ option(CONFIG_ZLIB "Enable zlib (de)compression" ON)

if (CONFIG_ZLIB)
add_library("zlib" STATIC)
if (BUILD_SHARED_LIBS)
set_property(TARGET "zlib" PROPERTY POSITION_INDEPENDENT_CODE ON)
endif()
set(zlib_group_PUBLIC_HEADERS
crc32.h
inffast.h
Expand Down
3 changes: 3 additions & 0 deletions libmatroska2/bzip2/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,9 @@
# bzlib library API

add_library("bzlib" STATIC)
if (BUILD_SHARED_LIBS)
set_property(TARGET "bzlib" PROPERTY POSITION_INDEPENDENT_CODE ON)
endif()
set(BZLIB_GROUP_PUBLIC_HEADERS
bzlib.h
)
Expand Down
3 changes: 3 additions & 0 deletions libmatroska2/minilzo/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,9 @@
# minilzo library API

add_library("minilzo" STATIC)
if (BUILD_SHARED_LIBS)
set_property(TARGET "minilzo" PROPERTY POSITION_INDEPENDENT_CODE ON)
endif()
Comment on lines +4 to +6
Copy link
Contributor

@robUx4 robUx4 Dec 31, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This contradicts the previous line where "minilzo" is only compiled as a STATIC library.

Copy link
Author

@alexrp alexrp Dec 31, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does it? The idea is to build minilzo as a static library, but still as PIC, because that static library gets incorporated into the matroska2 shared library.

set(MINILZO_GROUP_PUBLIC_HEADERS
minilzo.h
lzoconf.h
Expand Down