Draft
Conversation
Closes #53 - Introduce per-domain CSP policy resolution via DomainKeyResolver so different Umbraco domains can have their own CSP definitions - Add CspDomainsController to expose domain info to the backoffice - Add DomainPolicyMigration to extend the database schema - Add 'Add domain policy' tree action and modal in the backoffice - Regenerate OpenAPI client to include domain endpoints - Wire Playwright webServer config so tests can start the test site automatically - Add playwright CI job to csp-manager.yml running in parallel with build Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Use CspDefinitionSchema (without DomainKey) for the initial migration insert to avoid SQLite errors when the column doesn't exist yet. Make appSettings environment JSON optional so the test site starts in CI where appSettings.Development.json is absent. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Bumps actions/upload-artifact and actions/download-artifact from v4 to v5 to resolve Node.js 20 deprecation warnings ahead of the June 2026 forced Node.js 24 migration. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Tests cover domain middleware selection and fallback, domain cache invalidation, service CRUD for domain definitions, and validation rules for domain API models. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
DomainKeyResolverso different Umbraco domains can have their own CSP definitions (closes Add functionality to make settings domain specific #53)CspDomainsControllerto expose domain info to the backofficeDomainPolicyMigrationto extend the database schemawebServerconfig so tests auto-start the test siteplaywrightCI job incsp-manager.ymlrunning in parallel with the existingbuildjobTest plan
npm testlocally — all 9 Playwright tests passplaywrightCI job passes in GitHub Actions🤖 Generated with Claude Code