feat: add API key namespace restriction, MODULE_FULL type and g… - #106
Open
markdjones82 wants to merge 10 commits into
Open
feat: add API key namespace restriction, MODULE_FULL type and g…#106markdjones82 wants to merge 10 commits into
markdjones82 wants to merge 10 commits into
Conversation
…it provider UI - Add optional namespace restriction to upload and publish API keys - Store matched DB-backed API key on Flask g during authentication - Add MODULE_FULL api key type granting both upload and publish permissions - Add namespace restriction field to API Keys UI - Add git provider management UI page - Add provider sources UI page - New alembic migrations for api_key table and namespace column
MatthewJohn
reviewed
May 13, 2026
| 'post': [terrareg.auth_wrapper.auth_wrapper('is_admin')] | ||
| } | ||
|
|
||
| def _post_arg_parser(self): |
Owner
There was a problem hiding this comment.
With these changes to the API, there's a script scripts/generate_readme.py (badly named), which will update the API docs with the new endpoint specs :)
Contributor
Author
There was a problem hiding this comment.
I am getting module errors when trying to run the generate :/
|
|
||
|
|
||
| class ApiTerraregGitProviders(ErrorCatchingResource): | ||
| """Interface to obtain git provider configurations.""" |
Owner
There was a problem hiding this comment.
Could you update this to include both retrieving, create, modifying and deleting?
Contributor
Author
There was a problem hiding this comment.
Not sure what to change here, retrieve/create is handled by the collection class and modify/delete are in the item class. Were you thinking it be done a different way?
Adds nullable column to allow scoping API keys to a namespace.
Update api key notification
markdjones82
marked this pull request as draft
May 23, 2026 21:00
Add delete along with revoke for API keys
markdjones82
marked this pull request as ready for review
May 24, 2026 20:06
Contributor
Author
|
Ok, updated and ready for a re-review. Feel free to take it from here if you like. I think I've modified it as best as I understand what you are looking for! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…it provider UI
Addresses:
#102
#105