Fitting refactor : supplementary and categorical input#223
Open
ouakouak wants to merge 1 commit into
Open
Conversation
…tive and supplementary. Force to input categorical columns.
This was referenced May 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This first PR enables users to pass categorical features as attributes of the class, and also introduces support for supplementary variables in the
fitmethod.At the moment, users are essentially required to explicitly specify categorical features, as no automatic type detection has been implemented yet. We could consider adding such a feature later if needed.
Regarding supplementary variables, I have only added the necessary preprocessing step and passed them as arguments to
super().fit.Apart from that, the rest of the implementation remains unchanged, aside from some renaming of attributes. All previously implemented parts (except for the initial preprocessing before the call to
super().fit) have simply been adapted to the new distinction between active attributes.For now, supplementary variables are fitted but not fully integrated into the downstream computations.
Also added a small description to the class but can be modified or improved if needed.