Docker config refactor

[kinghat]

more cleanup of the docker situation. afaict the only thing left is the API_URL at yarn build to deal with for publishing the images.

[MaxLeiter]

@reeseovine sorry for the ping again... would you mind checking this is what we expect when you have the chance? I want to be sure we're not shipping unnecessarily large docker images or anything.

[reeseovine]

That's odd, I wonder why the images are so much bigger. I think it might have to do with unnecessary files being carried over between stages, like package cache maybe.

Edit: Ok yeah I think it's leaving in the npm dev dependencies after they're needed.

[kinghat]

That's odd, I wonder why the images are so much bigger. I think it might have to do with unnecessary files being carried over between stages, like package cache maybe.

oh dang, you measured the differences between master and this pr? i looked and the final images were exactly the same size.

[reeseovine]

oh dang, you measured the differences between master and this pr? i looked and the final images were exactly the same size.

Yeah, here's main:

and here's your branch:

I think that's how you do it? I'm no docker expert.

[kinghat]

oh dang, you measured the differences between master and this pr? i looked and the final images were exactly the same size.

Yeah, here's main:

and here's your branch:

I think that's how you do it? I'm no docker expert.

ya you are correct. im not sure what i overlooked when comparing earlier. thanks for the catch @reeseovine 🙏 ill fix it this evening.

[reeseovine]

Ah here we go, I found the culprit

Just rm that near the end of the dockerfile and it should be good!

This is in the client btw. The server might be the same but it's worth looking.

[MaxLeiter]

@kinghat yarn cache clean should do the job

[kinghat]

Ah here we go, I found the culprit

Just rm that near the end of the dockerfile and it should be good!

This is in the client btw. The server might be the same but it's worth looking.

@kinghat yarn cache clean should do the job

i fiddled with that and couldnt get it to reduce the size. it is better than the last stage, the image to be published, is separate from the deps and build stages anyways. sorry again 🤦‍♂️

[reeseovine]

couldnt get it to reduce the size

Were you still looking at the size of the old one? I just built the latest changes and it looks much better:

Server looks good too:

[kinghat]

couldnt get it to reduce the size

Were you still looking at the size of the old one? I just built the latest changes and it looks much better:

Server looks good too:

thanks for building again. i dont think so as i was paying attention to the created time. but like the original issue, i thought they were the same size before i sent the PR, so anythings possible 😅

[reeseovine]

Oh do you mean it's the same size as before you started this PR? Personally I think they're both fine as they are in terms of size, which should answer Max's original question for me 😁

[kinghat]

Oh do you mean it's the same size as before you started this PR? Personally I think they're both fine as they are in terms of size, which should answer Max's original question for me grin

ya its the same size as before i pushed, but also, i double checked the size before i pushed and i must have looked at the wrong thing because they were not, as you found out.