Conversation
* feat: mania update * chore: cargo clippy
Beatmap decoding / conversion to mania used to apply osu's legacy sorting in preparation for difficulty calculation. Unfortunately, this sorting needs to happen *after* mods are applied. Hence, we first need to convert for specific mania mods, and then unconditionally clone the hitobjects so that we have mutable access and can sort them.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Latest difficulty & performance update
News post: https://osu.ppy.sh/home/news/2025-10-29-performance-points-star-rating-updates
As usual, breaking changes were applied to the structure of attribute types.
osu commit: 28c846b4d9366484792e27f4729cd1afa2cdeb66
osu-tools commit: ab97b64f60901952926b2121ddffb8976d7f8775
TODOs: