Add Tag component #11
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MaxymilianSa
requested changes
Jul 3, 2023
|
|
||
| const Tag = ({ variant, className, ...props }: TagProps) => ( | ||
| <div className={clsxm(tagVariants({ variant, className }))} {...props}> | ||
| {getTagVariantText(variant)} |
There was a problem hiding this comment.
I think u can use any string for tag. Not only 'hot', 'new' or 'popular' + translations. It will be hard to reuse in future, if u want use other languages.
| } | ||
| ); | ||
|
|
||
| export const getTagVariantText = (variant: TagVariants) => { |
There was a problem hiding this comment.
If u can type any text, it will be to delete.
|
|
Change second commit for sth like "Added storybook for tag component" or stash commits |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.