Skip to content

asn1parse: document behavior on unexpected tags #217

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: development
Choose a base branch
from
Open

asn1parse: document behavior on unexpected tags #217

wants to merge 1 commit into from

Conversation

DemiMarie
Copy link
Contributor

Description

mbedtls_asn1_get_tag() does not change *p if it returns MBEDTLS_ERR_ASN1_UNEXPECTED_TAG, and code both inside and outside of Mbed TLS relies on this. Document this behavior.

PR checklist

  • changelog not required because: documentation-only
  • framework PR not required
  • mbedtls development PR not required because: documentation-only
  • mbedtls 3.6 PR not required because: documentation-only
  • mbedtls 2.28 PR not required because: documentation-only
  • tests not required because: documentation-only

@DemiMarie
asn1parse: document behavior on unexpected tags
a5f18ec 
mbedtls_asn1_get_tag() does not change *p if it returns
MBEDTLS_ERR_ASN1_UNEXPECTED_TAG, and code both inside and outside of
Mbed TLS relies on this.  Document this behavior.

Signed-off-by: Demi Marie Obenour <[email protected]>
@gabor-mezei-arm gabor-mezei-arm added enhancement New feature or request needs-review Every commit must be reviewed by at least two team members needs-reviewer This PR needs someone to pick it up for review priority-medium Medium priority - this can be reviewed as time permits size-xs Estimated task size: extra small (a few hours at most) component-docs Docs / website issues filed here for tracking labels Mar 25, 2025
@gabor-mezei-arm gabor-mezei-arm moved this from In Development to In Review in Non-roadmap pull requests Mar 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
component-docs Docs / website issues filed here for tracking enhancement New feature or request needs-review Every commit must be reviewed by at least two team members needs-reviewer This PR needs someone to pick it up for review priority-medium Medium priority - this can be reviewed as time permits size-xs Estimated task size: extra small (a few hours at most)
Projects
Non-roadmap pull requests
Status: In Review
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@DemiMarie @gabor-mezei-arm