Skip to content

feat(drivers): Builtin CMAC driver use PSA cipher interface #249

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: development
Choose a base branch
from

Conversation

Harshal5
Copy link
Contributor

@Harshal5 Harshal5 commented Apr 8, 2025

Description

Current issue:

As far as I can understand for the psa_mac_ APIs to internally use an external cipher driver we would need to write a custom complete MAC driver. Writing a custom MAC driver would involve almost rewriting the mbedtls_psa_mac_ APIs.

Solution:

Instead we could update the builtin driver's mbedtls_psa_mac_ API usage of mbedtls_cipher_ with psa_cipher_ APIs. This would allow the usage of an external cipher driver with psa_mac_ API calls without rewriting the CMAC code.

Related

Fixes #211

PR checklist

Please remove the segment/s on either side of the | symbol as appropriate, and add any relevant link/s to the end of the line.
If the provided content is part of the present PR remove the # symbol.

@Harshal5 Harshal5 force-pushed the feat/builtin_cmac_driver_use_psa_crypto_interface branch from 8a351f6 to eea13a9 Compare April 8, 2025 02:51
@yanesca yanesca added enhancement New feature or request size-m Estimated task size: medium (~1w) needs-design-approval Needs design discussion / approval labels Apr 9, 2025
@yanesca yanesca moved this from In Development to In Review in Non-roadmap pull requests Apr 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request needs-design-approval Needs design discussion / approval size-m Estimated task size: medium (~1w)
Projects
Status: In Review
Development

Successfully merging this pull request may close these issues.

Can psa_mac_ APIs internally use an external cipher driver?
2 participants