Move X.509 OIDs out of crypto #252
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Gilles Peskine <[email protected]>
Signed-off-by: Gilles Peskine <[email protected]>
Signed-off-by: Gilles Peskine <[email protected]>
Signed-off-by: Gilles Peskine <[email protected]>
Move the corresponding declarations from tf-psa-crypto/include/mbedtls/oid.h to library/x509_internal.h. Signed-off-by: Gilles Peskine <[email protected]>
OID_INFO_STRINGS is always disabled when oid_definition_helpers.h is consumed inside TF-PSA-Crypto. In Mbed TLS, it is enabled when X.509 wants text information. Signed-off-by: Gilles Peskine <[email protected]>
Crypto never associates strings to OIDs. Signed-off-by: Gilles Peskine <[email protected]>
gilles-peskine-arm
added
size-s
5 tasks
| @@ -470,39 +443,6 @@ | |||
| extern "C" { | |||
| #endif | |||
|
|
|||
There was a problem hiding this comment.
A note for potential future improvements: the functions declared here are only used inside TF-PSA-Crypto, except mbedtls_oid_get_md_alg() which is also used in X.509 and PKCS7 in Mbed TLS.
There was a problem hiding this comment.
Actually mbedtls_oid_get_md_alg() is not used in crypto! It's only called from test_suite_md which validates the OID associated with each hash algorithm. So mbedtls_oid_get_md_alg() should move to X.509 as well.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move the definitions of OIDs that are only needed X.509 out of
oid.candoid.hout of TF-PSA-Crypto, and into the X.509 library in Mbed TLS.Note: this pull request does not work against the head of Mbed TLS. After it is merged, TF-PSA-Crypto can only be consumed by an Mbed TLS where Mbed-TLS/mbedtls#10125 is merged. As a consequence, the TF-PSA-Crypto CI will fail. Arranging for a compatibility period would be doable, but quite a bit of extra work.
PR checklist
oid.hisn't yet officially a private interface, but it will be)