Fix MSVC build issue from MbedTls issue 7087

[ccrugoPhilips]

Description

Refactored code causing build issues with MSVC toolset v142 and prior. This has been tracked under MbedTls issue 7087.

PR checklist

Please remove the segment/s on either side of the | symbol as appropriate, and add any relevant link/s to the end of the line.
If the provided content is part of the present PR remove the # symbol.

• changelog provided | not required because:
• framework PR provided Mbed-TLS/mbedtls-framework# | not required
• mbedtls development PR provided Mbed-TLS/mbedtls# | not required because:
• mbedtls 3.6 PR provided Mbed-TLS/mbedtls# | not required because:
• tests provided | not required because:

Notes for the submitter

Please refer to the contributing guidelines, especially the
checklist for PR contributors.

Help make review efficient:

• Multiple simple commits
  • please structure your PR into a series of small commits, each of which does one thing
• Avoid force-push
  • please do not force-push to update your PR - just add new commit(s)
• See our Guidelines for Contributors for more details about the review process.

[ronald-cron-arm]

Thanks for this contribution. We are not comfortable with the changes in crypto.h. Please see my comment below.

[ronald-cron-arm]

This defines a new API and we cannot really do that.

In #260 I have implemented another solution experimented in Mbed-TLS/mbedtls#7087 (see Mbed-TLS/mbedtls#7087 (comment)) we would be more comfortable with.

I've also worked on crypto_extra.h in #260 and looking at your code it seems we ended up with the same changes. I am happy to remove crypto_extra.h changes from #260 if you prefer.

[ccrugoPhilips]

Moving the include is indeed much simpler to fix build errors from crypto.h and crypto_struct.h; I'm not very familiar with the API so tried to avoid that. Will rollback my changes in those files.

I see in #260 that some non-regression testing for Mbed-TLS/mbedtls#7087 may be needed, should that be added in this PR? Would be nice to keep crypto_extra.h changes in this PR if you don't mind.

[ccrugoPhilips]

A couple of additional remarks:

The build issues reported in Mbed-TLS/mbedtls#7087 are not present anymore with VS2022 (MSVC toolset v143).

Added an extra fix for a warning being treated as error when MBEDTLS_PSA_KEY_STORE_DYNAMIC is disabled.