Skip to content

Remove temporary SHA3 definition #312

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
mpg merged 1 commit into from
Jun 16, 2025
Merged

Remove temporary SHA3 definition #312

mpg merged 1 commit into from
Jun 16, 2025

Conversation

@gabor-mezei-arm
Copy link
Contributor

@gabor-mezei-arm gabor-mezei-arm commented Jun 10, 2025

Remove the temporary definition for MBEDTLS_SHA3_C created for merging the removal of this macro.

PR checklist

Please remove the segment/s on either side of the | symbol as appropriate, and add any relevant link/s to the end of the line.
If the provided content is part of the present PR remove the # symbol.

@gabor-mezei-arm
Remove temporary SHA3 definition
0f14ad0 
Remove the temporary definition for MBEDTLS_SHA3_C created for
merging the rmoval of this macro.

Signed-off-by: Gabor Mezei <[email protected]>
@gabor-mezei-arm gabor-mezei-arm self-assigned this Jun 10, 2025
@gabor-mezei-arm gabor-mezei-arm added enhancement New feature or request needs-review Every commit must be reviewed by at least two team members needs-reviewer This PR needs someone to pick it up for review labels Jun 10, 2025
@gabor-mezei-arm gabor-mezei-arm added priority-high High priority - will be reviewed soon size-xs Estimated task size: extra small (a few hours at most) needs-ci Needs to pass CI tests labels Jun 10, 2025
felixc-arm
felixc-arm approved these changes Jun 11, 2025
View reviewed changes
Copy link
Contributor

@felixc-arm felixc-arm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@gabor-mezei-arm gabor-mezei-arm removed the needs-ci Needs to pass CI tests label Jun 11, 2025
@valeriosetti valeriosetti self-requested a review June 13, 2025 14:46
@github-project-automation github-project-automation bot moved this from In Development to Has Approval in Roadmap pull requests (new board) Jun 13, 2025
@valeriosetti valeriosetti added approved Design and code approved - may be waiting for CI or backports and removed needs-review Every commit must be reviewed by at least two team members needs-reviewer This PR needs someone to pick it up for review labels Jun 13, 2025
@mpg mpg added this pull request to the merge queue Jun 16, 2025
Merged via the queue into Mbed-TLS:development with commit 774f5cc Jun 16, 2025
3 of 5 checks passed
@github-project-automation github-project-automation bot moved this from Has Approval to Done in Roadmap pull requests (new board) Jun 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@valeriosetti valeriosetti valeriosetti approved these changes

+1 more reviewer

@felixc-arm felixc-arm felixc-arm approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@gabor-mezei-arm gabor-mezei-arm

Labels

approved Design and code approved - may be waiting for CI or backports enhancement New feature or request priority-high High priority - will be reviewed soon size-xs Estimated task size: extra small (a few hours at most)

Projects

Roadmap pull requests (new board)
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@gabor-mezei-arm @valeriosetti @felixc-arm @mpg