Test release preparation #555
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Gilles Peskine <[email protected]>
Restore the file deleted at 0679e3a Signed-off-by: Gilles Peskine <[email protected]>
Partial cherry-pick of 879cba1 from Mbed TLS: only the changes in `scripts/bump_version.sh`. This is needed to adapt to the changes in how versions are declared in `**/CMakeLists.txt`. Signed-off-by: Ronald Cron <[email protected]> Signed-off-by: Gilles Peskine <[email protected]>
* There is no X.509 or TLS library. * Doxygen files are generated from a CMake template and no longer hard-code the product version. * None of the generated files exist here, and they wouldn't need updating anyway since they don't get committed. Signed-off-by: Gilles Peskine <[email protected]>
Signed-off-by: Gilles Peskine <[email protected]>
Signed-off-by: Gilles Peskine <[email protected]>
Simulate the release of the next minor version, happening today. Work in separate Git directories, to avoid contaminating the source tree where `all.sh` is being run. The release process can make commits, which should definitely not go onto a developer's branch when they run `all.sh` locally. Signed-off-by: Gilles Peskine <[email protected]>
Test that the library from the tar can be built in a minimal environment (CMake, make, C compiler and a few basic shell commands). In particular, this environment does not include Python. (This assumes that CMake won't try to look for Python outside of `$PATH`, which does seem to be the case in practice.) Signed-off-by: Gilles Peskine <[email protected]>
Signed-off-by: Gilles Peskine <[email protected]>
gilles-peskine-arm
added
size-s
github-project-automation
bot
moved this to In Development
in Non-roadmap pull requests
gilles-peskine-arm
added
priority-high
github-project-automation
bot
moved this to In Development
in Roadmap pull requests (new board)
| #### Release preparation | ||
| ################################################################ | ||
|
|
||
| next_product_version () { |
Contributor
Author
There was a problem hiding this comment.
I'm not sure if the auxiliary functions here should move to framework/scripts/all-helpers.sh. They're pretty specific to release preparation.
| EOF | ||
| } | ||
|
|
||
| git_clone_recursively () { |
Contributor
Author
There was a problem hiding this comment.
I want to tidy up the handling of submodules (both cloning, and the dirty worktree check) before copying this to mbedtls. For crypto with just one submodule, it's ok. But for the multiple submodules of Mbed TLS, I'd like a loop. And if I write that loop I might as well use it here too.
Signed-off-by: Gilles Peskine <[email protected]>
Git command help is provided through man pages, which are not installed in our Docker images, `git archive --help | grep ...` was always failing. Use the Git version number instead. Signed-off-by: Gilles Peskine <[email protected]>
gilles-peskine-arm
added
the
needs-preceding-pr
fixup "Test the reproducibility of the release tar" Signed-off-by: Gilles Peskine <[email protected]>
Signed-off-by: Gilles Peskine <[email protected]>
Also list the sha and the files at the end of the build rather than midway through, for better visibility. Signed-off-by: Gilles Peskine <[email protected]>
Signed-off-by: Gilles Peskine <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses most of Mbed-TLS/mbedtls#3255 . What is left is to arrange for the Groovy code to pick up the release artifacts created by the new
all.shcomponent as Jenkins artifacts.Addresses most of Mbed-TLS/mbedtls-framework#231 by creating
bump_version.shin crypto. We might want to put this functionality intoprepare_release.py, but I'm not fully convinced: there are significant differences between branches with respect to what version bumping does, so I think the code to do that belongs in each branch.Fixes Mbed-TLS/mbedtls#9521 by testing that builds done in different directories result in identical tarballs.
Needs preceding PR:
bump_version.shnot to be incomplete: Fix duplication of product version in CMakeLists.txt #554PR checklist
prepare_release.pyfor 3.6