Skip to content

Add metatests for the fork test helper as unit tests #737

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
gilles-peskine-arm wants to merge 9 commits into
base: development
Choose a base branch
from
Open

Add metatests for the fork test helper as unit tests #737

Show file tree
Hide file tree
Changes from 7 commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
24dfab9
Update framework with TEST_STRSTR and fork helper using a regular file
gilles-peskine-arm Apr 3, 2026
3a45eae
Create a metatest test suite
gilles-peskine-arm Apr 3, 2026
c982f90
Test mbedtls_test_fork_run_child: normal child behavior, exit, signal
gilles-peskine-arm Apr 3, 2026
f2d48e8
mbedtls_test_fork_run_child: test common system failures
gilles-peskine-arm Apr 3, 2026
b25dcea
Fix the build on non-UNIXLIKE platforms
gilles-peskine-arm Apr 5, 2026
9e9f913
Fix the build on FreeBSD
gilles-peskine-arm Apr 5, 2026
aef9701
Make signal testing more robust
gilles-peskine-arm Apr 9, 2026
156eb2d
Improve robustness of tests using signals if the signal is blocked on…
gilles-peskine-arm Apr 10, 2026
0ab1f46
Note that some metatests may fail if you run as root
gilles-peskine-arm Apr 10, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion framework
Open in desktop
Submodule framework updated 4 files
+39 −0 tests/include/test/helpers.h
+17 −0 tests/include/test/macros.h
+106 −103 tests/src/fork_helpers.c
+41 −0 tests/src/helpers.c
50 changes: 50 additions & 0 deletions tests/suites/test_suite_metatest.basic.data
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,50 @@
metatest: pass
metatest_simple:DO_PASS:0:MBEDTLS_TEST_RESULT_SUCCESS:""

metatest: don't skip
metatest_simple:DO_ASSUME:1:MBEDTLS_TEST_RESULT_SUCCESS:""

metatest: skip
metatest_simple:DO_ASSUME:0:MBEDTLS_TEST_RESULT_SKIPPED:"param"

metatest: fail
metatest_simple:DO_FAIL:0:MBEDTLS_TEST_RESULT_FAILED:"hello"

metatest: first failure sets the message
metatest_simple:DO_FAIL_TWICE:0:MBEDTLS_TEST_RESULT_FAILED:"first failure"

metatest: assert true
metatest_simple:DO_ASSERT:1:MBEDTLS_TEST_RESULT_SUCCESS:""

metatest: assert false
metatest_simple:DO_ASSERT:0:MBEDTLS_TEST_RESULT_FAILED:"param"

metatest: 42==42 pass
metatest_simple:DO_EQUAL_42:42:MBEDTLS_TEST_RESULT_SUCCESS:""

metatest: 41==42 fail
metatest_simple:DO_EQUAL_42:41:MBEDTLS_TEST_RESULT_FAILED:" == "

metatest: 42<=42 signed pass
metatest_simple:DO_LE_S_42:42:MBEDTLS_TEST_RESULT_SUCCESS:""

metatest: 41<=42 signed pass
metatest_simple:DO_LE_S_42:41:MBEDTLS_TEST_RESULT_SUCCESS:""

metatest: 43<=42 signed fail
metatest_simple:DO_LE_S_42:43:MBEDTLS_TEST_RESULT_FAILED:" <= "

metatest: -1<=42 signed pass
metatest_simple:DO_LE_S_42:-1:MBEDTLS_TEST_RESULT_SUCCESS:""

metatest: 42<=42 unsigned pass
metatest_simple:DO_LE_U_42:42:MBEDTLS_TEST_RESULT_SUCCESS:""

metatest: 41<=42 unsigned pass
metatest_simple:DO_LE_U_42:41:MBEDTLS_TEST_RESULT_SUCCESS:""

metatest: 43<=42 unsigned fail
metatest_simple:DO_LE_U_42:43:MBEDTLS_TEST_RESULT_FAILED:" <= "

metatest: -1<=42 unsigned fail
metatest_simple:DO_LE_U_42:-1:MBEDTLS_TEST_RESULT_FAILED:" <= "
54 changes: 54 additions & 0 deletions tests/suites/test_suite_metatest.fork.data
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,54 @@
metatest fork: pass, 0/0 bytes
metatest_fork_output:MBEDTLS_TEST_RESULT_SUCCESS:"":0:0:""

metatest fork: pass, 0/42 bytes
metatest_fork_output:MBEDTLS_TEST_RESULT_SUCCESS:"":42:0:""

metatest fork: pass, 41/42 bytes
metatest_fork_output:MBEDTLS_TEST_RESULT_SUCCESS:"49276d20426f6262696e20546872656164626172652c2061726520796f75206d79206d6f746865723f":1:0:""

metatest fork: pass, 42/42 bytes
metatest_fork_output:MBEDTLS_TEST_RESULT_SUCCESS:"0049276d20426f6262696e20546872656164626172652c2061726520796f75206d79206d6f746865723f":0:0:""

metatest fork: large output
metatest_fork_large_output:2 * PIPE_BUF

metatest fork: report excess length
metatest_fork_output:MBEDTLS_TEST_RESULT_SUCCESS:"0049276d20426f6262696e20546872656164626172652c2061726520796f75206d79206d6f746865723f":0:1:" <= "

metatest fork: skip
metatest_fork_output:MBEDTLS_TEST_RESULT_SKIPPED:"":0:0:"metatesting skipping in child"

metatest fork: fail
metatest_fork_output:MBEDTLS_TEST_RESULT_FAILED:"":0:0:"metatesting failure in child"

metatest fork: SIGTERM
metatest_fork_die:SIGTERM:-1:"wstatus"

metatest fork: SIGKILL
metatest_fork_die:SIGKILL:-1:"wstatus"

metatest fork: exit(0)
metatest_fork_die:0:0:"died without reporting"

metatest fork: exit(1)
metatest_fork_die:0:1:"wstatus"

metatest fork: fault fork()
metatest_fork_system_failure:FORK_FAIL_FORK:"pid"

metatest fork: fault parent creating temporary file
metatest_fork_system_failure:FORK_FAIL_OPEN:"file != NULL"

metatest fork: fault parent preparing temporary file
# The write failure may be detected in fwrite() or fflush().
metatest_fork_system_failure:FORK_FAIL_WRITE_INIT:"file"

metatest fork: fault child writing result
# The child fails to write its result, so it exits with a nonzero status.
metatest_fork_system_failure:FORK_FAIL_WRITE_RESULT:"wstatus"

metatest fork: fault child writing output
# The write failure may be detected in fwrite() or fflush().
metatest_fork_system_failure:FORK_FAIL_WRITE_OUTPUT:"file"

Loading