Skip to content

Adjust scripts to accommodate public header move #156

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 16, 2025

Conversation

felixc-arm
Copy link
Contributor

Companion PR to Mbed-TLS/TF-PSA-Crypto#247. Supports the move of public headers from tf-psa-crypto/drivers/builtin/include/mbedtls to tf-psa-crypto/include/mbedtls.

Contributes to Mbed-TLS/TF-PSA-Crypto#223

PR checklist

Please add the numbers (or links) of the associated pull requests for consuming branches. You can omit branches where this pull request is not needed.

@felixc-arm
Copy link
Contributor Author

I'm not entirely sure why this failed the CI - the failures seem unrelated and are perhaps caused by the last commit 60c8e52? In any case the mbedtls CI passes using this patch (Mbed-TLS/mbedtls#10122) & the TF-PSA-Crypto patch.

@felixc-arm felixc-arm added needs-review Every commit must be reviewed by at least two team members, needs-reviewer This PR needs someone to pick it up for review labels Apr 10, 2025
@gilles-peskine-arm
Copy link
Contributor

All the CI failures are in 3.6 jobs. But I don't understand the way in which they're failing, it doesn't seem related to your changes.

******************************************************************
* test_default_out_of_box: program demos: make, default config (out-of-box) 
* Wed Apr  9 10:12:11 UTC 2025
******************************************************************
programs/psa/psa_hash_demo.sh: 46: programs/psa/../../framework/scripts/demo_common.sh: is_mbedtls_root: not found
programs/psa/psa_hash_demo.sh: 52: programs/psa/../../framework/scripts/demo_common.sh: is_tf_psa_crypto_root: not found
…

@valeriosetti valeriosetti self-requested a review April 14, 2025 09:43
@felixc-arm felixc-arm removed the needs-reviewer This PR needs someone to pick it up for review label Apr 15, 2025
@felixc-arm felixc-arm added approved Design and code approved - may be waiting for CI or backports and removed needs-review Every commit must be reviewed by at least two team members, labels Apr 15, 2025
@gilles-peskine-arm
Copy link
Contributor

It's unclear how to merge the consuming pull requests in crypto and mbedtls development, but the framework PR doesn't break anything on its own, so I'm going ahead and merging it.

@gilles-peskine-arm gilles-peskine-arm merged commit 9e612a4 into Mbed-TLS:main Apr 16, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Design and code approved - may be waiting for CI or backports
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants