remove compat-2.x.h #160
Open
remove compat-2.x.h #160
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 tasks
Signed-off-by: Ben Taylor <[email protected]>
bjwtaylor
force-pushed
the
remove-compat-2
branch
from
50221dc to
bb8d07d
Compare
bjwtaylor
added
needs-review
felixc-arm
reviewed
Apr 28, 2025
There was a problem hiding this comment.
This'll break 3.6 CI right? So presumably the main mbedtls change isn't suitable for a backport as it'll break the API (by removing backwards compatibility for 3.6 vs 2.x?), so this change shouldn't be made (or should be guarded so that the compat-2.x.h exclusion is present for 3.6 and removed for 4.x).
Unless of course I'm mistaken and the main mbedtls PR should be backported - it does say in compat-2.x.h that it is deprecated so perhaps that is the intention? (although I'm not sure if deprecated things get removed between minor versions or just in major versions)...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Remove include/mbedtls/compat-2.x.h and its reference in check_names.py.
PR checklist