-
Notifications
You must be signed in to change notification settings - Fork 2.8k
Add functions to export TLS traffic keys and sequence numbers for KTLS integration #10457
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: development
Are you sure you want to change the base?
Conversation
Signed-off-by: HaniAmmar <[email protected]>
Signed-off-by: HaniAmmar <[email protected]>
Signed-off-by: HaniAmmar <[email protected]>
Signed-off-by: HaniAmmar <[email protected]>
Signed-off-by: HaniAmmar <[email protected]>
Signed-off-by: HaniAmmar <[email protected]>
Signed-off-by: HaniAmmar <[email protected]>
|
Thank you very much for contributing this feature! Due to the size, I'm afraid it might take a while for us to review it. Unfortunately, review bandwidth is a major bottleneck for us. A small note: this is a new feature of significant size, so we will not backport it to a long-time support branch. |
|
Hi @HaniAmmar, thanks so much for contributing this! We've looked at it and discussed internally. We won't have enough bandwidth to review this whole PR at once because it is quite large. Would you mind splitting it out into 2 smaller PRs, one containing the new functions and tests and the other adding the example program? One other minor thing - I notice that you've written test functions with all of the possible test cases inside them - would you be able to refactor that so that the test functionality is in the Once the PR is split we can schedule it for review on the community board. |
|
That won’t be a problem. I’ll address it once I’m back from my current vacation. Thank you. |
Description
This pull request introduces new public APIs that allow external components (such as Kernel TLS) to access TLS traffic secrets and sequence numbers in a controlled manner.
These additions make it possible to implement KTLS handover or other advanced integrations without modifying Mbed TLS internals.
See: #10425
PR checklist