-
Notifications
You must be signed in to change notification settings - Fork 2.8k
Update the pkalgs domain to use PSA macros in depends.py
#9654
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update the pkalgs domain to use PSA macros in depends.py
#9654
Conversation
7c4a029 to
174d116
Compare
174d116 to
7acd70b
Compare
minosgalanakis
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
@gabor-mezei-arm This has a conflict. @ronald-cron-arm Kind reminder that this is waiting for your review :) |
|
@ronald-cron-arm Are you still planning to review this? We're trying to close off our DI task and we have one that depends on this. |
|
@mpg I can see that you already pinged me about the review of this PR but I somehow missed it, sorry about that. I looked at this PR sometimes ago, I can finalize my review of it. |
|
@gabor-mezei-arm could you rebase to resolve the conflict? Thanks. |
7acd70b to
9c3e433
Compare
Signed-off-by: Gabor Mezei <[email protected]>
9c3e433 to
f13fd1e
Compare
No worries. Quite ironically, I missed the notification about your reply, and only saw it today while checking the status of the PR :)
Great, thanks! |
ronald-cron-arm
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PR changes the definitions of the pkalgs complementaty domains to be based on PSA_WANT_ symbols instead of MBEDTLS_ ones, in preparation of the removal of the MBEDTLS_ symbols as configuration options. The MbedTLS configurations that are tested as part of the pkalgs complementary domain remain the same. Thus this can be merged as it is to me.
After that step, we would probably want to adapt the definition of the pkalgs domain to the specifics of the PSA_WANT_ symbols compared to the MBEDTLS_ ones. For example, having a test where only PSA_WANT_ALG_RSA_OAEP is disabled and another one where PSA_WANT_ALG_RSA_PSS is disabled, whereas currently we only have one test that disables both. We would also probably want to keep the test where both are disabled and to have the three cases we need to add support for grouping as discussed in #9634.
|
I'm not super familiar with the concept of grouping as discussed in 9634. @gabor-mezei-arm can you create (an) issue(s) to track the follow-up(s) that Ronald is suggesting? Then add it/them to the 4.0 board, probably as SHOULDs in the "PSA Crypto always on" topic? Thanks in advance. |
minosgalanakis
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Description
In
depends.pyuse PSA macros for thepkalgsdomain.Resolve #9145
Depends on #9292(merged)PR checklist
Please remove the segment/s on either side of the | symbol as appropriate, and add any relevant link/s to the end of the line.
If the provided content is part of the present PR remove the # symbol.