Mbedtls 3.6 subslotting #9876
Open
Mbedtls 3.6 subslotting #9876
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
Use standard `CMAKE_INSTALL_INCLUDEDIR` and `CMAKE_INSTALL_LIBDIR` location to define headers and library installation. This variable can be redefined on configuration phase to allow install headers and libraries to different location (like `include/mbedtls3`, Mbed-TLS#8723). Additionally removing explicit permission rules as they may broke proper permissions for system installation (like remove executable bit from libraries). By default CMake sets permissions correctly on all files and directories. See Mbed-TLS#8723 for rationale. Signed-off-by: Azamat H. Hackimov <[email protected]>
Convert main library targets to slottable versions. This allows to install major versions of MbedTLS simultaneously. Dependent packages should use `find_package(MbedTLS 3 [REQUIRED])` and `MbedTLS::<component>` in order to use requested libraries. Signed-off-by: Azamat H. Hackimov <[email protected]>
Convert main library targets to slottable versions. This allows to install major versions of MbedTLS simultaneously. Dependent packages should use `pkg-config --libs --cflags (mbedtls3|mbedx5093|mbedx5093)` in order to use requested libraries. Signed-off-by: Azamat H. Hackimov <[email protected]>
Signed-off-by: Azamat H. Hackimov <[email protected]>
winterheart
force-pushed
the
mbedtls-3.6-subslotting
branch
from
1221602 to
be062f4
Compare
3 tasks
ronald-cron-arm
added
component-platform
|
Thank you very much for this contribution. This seems a good improvement and the PR seems in a good shape. I have triggered the CI. |
|
Regarding to test failures: I can make version suffix addition optional via cmake |
Make version suffix appending optional. Change suffix to include dash symbol to comply pkg-config naming conventions. Signed-off-by: Azamat H. Hackimov <[email protected]>
winterheart
force-pushed
the
mbedtls-3.6-subslotting
branch
from
e534656 to
3e51f0c
Compare
|
I've added |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR allows to install major versions of MbedTLS simultaneously.
Dependent packages should use
find_package(MbedTLS 3 [REQUIRED])andMbedTLS::<component>in order to use requested libraries. Packages that relies on pkg-config output, should usepkg-config --libs --cflags (mbedtls3|mbedx5093|mbedx5093)output in order to discover actual library names and include paths.Fixes #8723
PR checklist
Please remove the segment/s on either side of the | symbol as appropriate, and add any relevant link/s to the end of the line.
If the provided content is part of the present PR remove the # symbol.
Notes for the submitter
Please refer to the contributing guidelines, especially the
checklist for PR contributors.
Help make review efficient: