Bugfixes #86
Open
Bugfixes #86
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Main thing is I think your build will now be marked as passing with this update. Tests were failing on hyperspeed print. I've tested on on windows and mac, it appears to be working.
The # symbol was printing with quotes around it. Since it is a config file you don't need the quotes. Some parsers will incorrectly show it is a comment, but it functions correctly now and only outputs the # symbol with no quotes.
Last thing is windows doesn't support
os.system('clear'). I added and tested the corresponding windows clear command.Great program! Really appreciate your work in getting it this far. Hope to add a feature or two someday soon.