Draft: Basic CLI Export Support#437
Draft
m10653 wants to merge 3 commits into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Very rough start to add command line support to Advantage Scope. Right now just focusing on merging and exporting files. However in the future plan on adding the ability to specify what logs to open along with what template/view to use. This would enable the creation of desktop shortcuts for different layouts/views as well as possibly adding file handlers advantage scope compatible log files.
Currently the following pr has quite a few issues. The main one being how I am handling the WASM indexer for wpilog files. I had a lot of issues generating a valid wasm binary that would work for both node and web scopes, so a quick work around was to compile it twice with different command line args.
Architecturally right now log loading code is highly coupled to electron as a lot of the logic exists within the web workers. I played around a bit with breaking this off into FileLoader classes, although this breaks down a little bit with progress updates, wasm, as well as the lazy loading done with wpilogs (field loading logic is handled within the historical log record class)
Example Command line args