Merge remote-tracking branch 'origin/bayRentalFix' into bayRentalFix

Author: IllianiBird

MekHQ/src/mekhq/campaign/mission/rentals/FacilityRentals.java

@@ -460,18 +460,32 @@ private static boolean performRentalTransaction(Finances finances, LocalDate tod
               getFormattedTextAt(RESOURCE_BUNDLE, "FacilityRentals.rental." + rentalType, rentalCost.toAmountString()));
     }
 
+    /**
+     * Processes a request to change bay assignments for the specified units, offering bay rental opportunities
+     * if allowed by the current campaign state.
+     * <p>
+     * Bay rentals are only permitted if the campaign is either off-contract or on a garrison-type contract,
+     * and the campaign's location is planetside. If these conditions are not met, a dialog is shown to the user
+     * indicating that no facilities are available.
+     * </p>
+     *
+     * @param campaign      the current campaign context
+     * @param selectedUnits the units for which bay changes are requested
+     * @param bayType       the type of bay being requested (e.g., {@link Unit#SITE_FACILITY_MAINTENANCE}, {@link Unit#SITE_FACTORY_CONDITIONS})
+     * @return {@code true} if the bay change process can proceed; {@code false} if not allowed (e.g., due to contract or location restrictions)
+     */
     public static boolean processBayChangeRequest(Campaign campaign, Unit[] selectedUnits, int bayType) {
         List<AtBContract> activeAtBContracts = campaign.getActiveAtBContracts();
-        boolean isOffContractOrOnGarrison = activeAtBContracts.isEmpty();
+        boolean isBayRentalAllowed = activeAtBContracts.isEmpty();
 
         for (AtBContract atBContract : activeAtBContracts) {
             if (atBContract.getContractType().isGarrisonType()) {
-                isOffContractOrOnGarrison = true;
+                isBayRentalAllowed = true;
                 break;
             }
         }
 
-        if (!isOffContractOrOnGarrison || !campaign.getLocation().isOnPlanet()) {
+        if (!isBayRentalAllowed || !campaign.getLocation().isOnPlanet()) {
             BayRentalDialog.showNoFacilitiesAvailableDialog(campaign);
             return false;
         }