Skip to content

Commit d1e8e45

Browse files
authored
Merge pull request #4115 from IllianiCBT/autoAwards_FixAwardImageDisplayAgain
Fixed Award Image Display in Person View
2 parents de738f5 + 64390e3 commit d1e8e45

File tree

1 file changed

+16
-6
lines changed

1 file changed

+16
-6
lines changed

Diff for: MekHQ/src/mekhq/gui/view/PersonViewPanel.java

+16-6
Original file line numberDiff line numberDiff line change
@@ -18,6 +18,7 @@
1818
*/
1919
package mekhq.gui.view;
2020

21+
import megamek.codeUtilities.MathUtility;
2122
import megamek.common.options.IOption;
2223
import mekhq.MHQStaticDirectoryManager;
2324
import mekhq.MekHQ;
@@ -341,8 +342,11 @@ private Box drawRibbons() {
341342
rowRibbonsBox.setBackground(Color.RED);
342343
}
343344
try {
344-
int awardTierCount = Math.min(award.getNumberOfMedalFiles(),
345-
Math.max(1, person.getAwardController().getNumberOfAwards(award) / campaign.getCampaignOptions().getAwardTierSize()));
345+
int awardTierCount = MathUtility.clamp(
346+
(person.getAwardController().getNumberOfAwards(award) / campaign.getCampaignOptions().getAwardTierSize()) + 1,
347+
1,
348+
award.getNumberOfRibbonFiles()
349+
);
346350

347351
String ribbonFileName = award.getRibbonFileName(awardTierCount);
348352

@@ -393,8 +397,11 @@ private JPanel drawMedals() {
393397

394398
Image medal;
395399
try {
396-
int awardTierCount = Math.min(award.getNumberOfMedalFiles(),
397-
Math.max(1, person.getAwardController().getNumberOfAwards(award) / campaign.getCampaignOptions().getAwardTierSize()));
400+
int awardTierCount = MathUtility.clamp(
401+
(person.getAwardController().getNumberOfAwards(award) / campaign.getCampaignOptions().getAwardTierSize()) + 1,
402+
1,
403+
award.getNumberOfMedalFiles()
404+
);
398405

399406
String medalFileName = award.getMedalFileName(awardTierCount);
400407

@@ -442,8 +449,11 @@ private JPanel drawMiscAwards() {
442449

443450
Image miscAward;
444451
try {
445-
int awardTierCount = Math.min(award.getNumberOfMedalFiles(),
446-
Math.max(1, person.getAwardController().getNumberOfAwards(award) / campaign.getCampaignOptions().getAwardTierSize()));
452+
int awardTierCount = MathUtility.clamp(
453+
(person.getAwardController().getNumberOfAwards(award) / campaign.getCampaignOptions().getAwardTierSize()) + 1,
454+
1,
455+
award.getNumberOfMiscFiles()
456+
);
447457

448458
String miscFileName = award.getMiscFileName(awardTierCount);
449459

0 commit comments

Comments
 (0)