Finance module errors

[jbhuddleston]

Environment

0.46.0-rc.2
Java vendor AdoptOpenJDK
Java version 11.0.3
Platform Windows 7 6.1 (amd64)
Total memory available to MegaMek: 1,048,576 kB

Description

Three issues, two are straightforward.

1. salaries if payForSalaries=true and usePeacetimeCost=true and showPeacetimeCost=false then salaries are paid inside PeacetimeCosts and again as a separate transaction. If payForSalaries=false then no salaries are paid. Only if payForSalaries=true and usePeacetimeCost=true and showPeacetimeCost=true are salaries paid only once.

2. maintenance With: checkMaintenance=true, maintenanceCycleDays=14 and useUnofficalMaintenance=true I am paying the correct amount of maint costs every 14 days when the maint check is performed and those costs are correctly calculated for the display in the Hangar tab, however, the listing in Monthly expenses for Maintenance remains twice the Maintenance cost for each unit even when maint checks are conducted three times in a calendar month. This has no effect on finances, however, as that figure is never processed as a transaction, only the maint check costs; this means that the 10% maint cost for mothballed units is never paid. (Where did that come from BTW as SO-p176 states that there will be no maint checks which implies no maint costs.) I recommend that the Maintenance entry for Monthly Expenses forecasting be based on the maint checks planned for current units in the coming calendar month. Also, it should be moved out from the middle of the sequence of peacetime operating costs.

3. training ammunition These costs are being miscalculated but I ran out of time looking in the code trying to find out where. I have only one unit for which it was calculated correctly and it has 4 AC2s in the same location and 4 tons of CB1000 ammo --> trg cost =1000. An original Fortress Dropship is calculated at nearly 10 times the correct value at CB2,300,000. A Dropship with only AC2s spread over 6 bays and with 40t of CB1000 ammo (trg cost CB10,000) is being calculated as CB68,000. I have started a fresh campaign using CO campaign settings and the problem exists there too.

Files

I am pretty sure that my files will not assist you in finding these problems but they are included as requested.
FourAmigos.zip

Best regards,
James

[sixlettervariables]

I'm thinking for (1) the correct answer is to never include salaries in peacetime costs. Thoughts?

The code will then use salaries if you've elected to use salaries.

Alternatively we'd just change how we aggregate peacetime costs for showing vs debiting.

[sixlettervariables]

For (2) we take the weekly cost and multiply it by 4 when displaying the financial report. Given the maintenance cycle duration is variable, that might be difficult to calculate. We'd need to know the last date of maintenance per unit and project out the costs.

[jbhuddleston]

Regarding (1) if the player is never given the option to aggregate the peacetime costs and you make the change to not include salaries in them then it will behave correctly.

[jbhuddleston]

Regarding (2) you are correct and I am pretty sure you would not want to alter the model to daily calculations in order to make it more flexible. I do think it would be worth the effort to forecast the actual expenses within a calendar month as your payment cycle is tied to it as well. As you are also unlikely to want to shift payments to a weekly schedule then the accurate calendar month forecast appears to be necessary.

[jbhuddleston]

Regarding (3) in the interim, I am calculating the overpayment for each unit and crediting it as income every month.