Merged
Conversation
rollandf
force-pushed
the
workflow
branch
2 times, most recently
from
21da5dd to
6099691
Compare
maze88
reviewed
Sep 15, 2025
entrypoint/Makefile
Outdated
|
|
||
| .PHONY: check-go-modules | ||
| check-go-modules: generate-go-modules | ||
| git diff --quiet HEAD go.sum; if [ $$? -eq 1 ] ; then echo "go.sum is out of date. Please commit after running 'make generate-go-modules' command"; exit 1; fi |
Collaborator
There was a problem hiding this comment.
suggest using existing git diff --exit-code capability, something like:
git diff --quiet --exit-code HEAD go.sum || (echo "go.sum is out of date. Please commit after running 'make generate-go-modules' command"; exit 1)
maze88
approved these changes
Sep 15, 2025
Signed-off-by: Fred Rolland <frolland@nvidia.com>
maze88
approved these changes
Sep 15, 2025
almaslennikov
approved these changes
Sep 16, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.