Merged
Conversation
almaslennikov
approved these changes
Sep 16, 2025
Pull Request Test Coverage Report for Build 17937633325Details
💛 - Coveralls |
e0ne
reviewed
Sep 18, 2025
entrypoint/internal/driver/driver.go
Outdated
| log := logr.FromContextOrDiscard(ctx) | ||
| log.V(1).Info("Generating OFED modules blacklist") | ||
|
|
||
| // Ensure the directory exists |
Collaborator
There was a problem hiding this comment.
Why we need this check and mkdir call? we store config in /host/etc/modprobe.d/ and it should exists
e0ne
requested changes
Sep 22, 2025
entrypoint/internal/driver/driver.go
Outdated
| @@ -117,6 +118,12 @@ func (d *driverMgr) Build(ctx context.Context) error { | |||
| // Load is the default implementation of the driver.Interface. | |||
| func (d *driverMgr) Load(ctx context.Context) (bool, error) { | |||
| // TODO: Implement | |||
Signed-off-by: Fred Rolland <frolland@nvidia.com>
e0ne
approved these changes
Sep 25, 2025
Collaborator
e0ne
left a comment
e0ne
left a comment
There was a problem hiding this comment.
Thanks for addressing my comments
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.