feat: Go implement lsmod and rmmod#130
Merged
rollandf merged 1 commit intoMellanox:mainfrom Sep 18, 2025
Merged
Conversation
almaslennikov
approved these changes
Sep 16, 2025
Pull Request Test Coverage Report for Build 17822388441Details
💛 - Coveralls |
e0ne
reviewed
Sep 18, 2025
| // RmMod is the default implementation of the host.Interface. | ||
| func (h *host) RmMod(ctx context.Context, module string) error { | ||
| // TODO: add implementation | ||
| // Execute rmmod command to unload the kernel module |
Collaborator
There was a problem hiding this comment.
nit: we can use sys/unix.DeleteModule. but I like the current approach for the consistency between methods
e0ne
approved these changes
Sep 18, 2025
Signed-off-by: Fred Rolland <frolland@nvidia.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.