fix: disable xpmem modules in SLES driver build#250
Merged
dahalperin merged 1 commit intomainfrom Feb 10, 2026
Merged
Conversation
Greptile OverviewGreptile SummaryThis PR disables XPMEM in SLES driver builds by adding Changes are applied consistently across:
Net effect: SLES builds should no longer attempt to build/package xpmem components, aligning SLES behavior with the existing approach of excluding optional modules during driver build. Confidence Score: 5/5
Important Files Changed
Sequence DiagramsequenceDiagram
participant BuildSystem as CI/Build System
participant Dockerfile as SLES_Dockerfile
participant EntrypointSh as entrypoint.sh
participant DriverGo as driver.go (driverMgr)
participant InstallPl as install.pl
alt Precompiled SLES image build
BuildSystem->>Dockerfile: RUN install.pl ... --without-xpmem --without-xpmem-modules
Dockerfile->>InstallPl: invoke build-only kernel modules
InstallPl-->>Dockerfile: RPMS generated (xpmem omitted)
else Sources container runtime build on SLES
BuildSystem->>EntrypointSh: build_driver_from_src()
EntrypointSh->>InstallPl: install.pl ... --kernel-sources ... --without-xpmem --without-xpmem-modules
InstallPl-->>EntrypointSh: RPMS generated (xpmem omitted)
else Go entrypoint runtime build on SLES
BuildSystem->>DriverGo: Build(ctx)
DriverGo->>DriverGo: getBuildFlagsForOS(SLES)
DriverGo->>InstallPl: RunCommand(install.pl, ... --without-xpmem --without-xpmem-modules)
InstallPl-->>DriverGo: build succeeds without xpmem
end
|
46aa92a to
f09a78e
Compare
Signed-off-by: Dana Halperin <dahalperin@nvidia.com>
f09a78e to
5ae6034
Compare
rollandf
approved these changes
Feb 10, 2026
heyvister1
approved these changes
Feb 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.