Skip to content

fix: disable xpmem modules in SLES driver build#250

Merged
dahalperin merged 1 commit intomainfrom
remove_xpmem
Feb 10, 2026
Merged

fix: disable xpmem modules in SLES driver build#250
dahalperin merged 1 commit intomainfrom
remove_xpmem

Conversation

@dahalperin
Copy link
Contributor

No description provided.

@greptile-apps
Copy link

greptile-apps bot commented Feb 10, 2026

Greptile Overview

Greptile Summary

This PR disables XPMEM in SLES driver builds by adding --without-xpmem and --without-xpmem-modules to the install.pl invocation.

Changes are applied consistently across:

  • the SLES Dockerfile precompiled build step,
  • the bash entrypoint SLES source-build flags, and
  • the Go-based entrypoint SLES build flags and its unit test expectation.

Net effect: SLES builds should no longer attempt to build/package xpmem components, aligning SLES behavior with the existing approach of excluding optional modules during driver build.

Confidence Score: 5/5

  • This PR is safe to merge with minimal risk.
  • The change is a narrow, consistent flag addition across Dockerfile, bash entrypoint, Go entrypoint, and tests; no interface changes or control-flow changes were introduced.
  • No files require special attention

Important Files Changed

Filename Overview
SLES_Dockerfile Adds xpmem disable flags to the SLES install.pl build step.
entrypoint.sh Adds --without-xpmem and --without-xpmem-modules to SLES source build flags.
entrypoint/internal/driver/driver.go Extends SLES OS build flags to include disabling xpmem modules.
entrypoint/internal/driver/driver_test.go Updates SLES build test to expect the new xpmem disable flags in install.pl args.

Sequence Diagram

sequenceDiagram
  participant BuildSystem as CI/Build System
  participant Dockerfile as SLES_Dockerfile
  participant EntrypointSh as entrypoint.sh
  participant DriverGo as driver.go (driverMgr)
  participant InstallPl as install.pl

  alt Precompiled SLES image build
    BuildSystem->>Dockerfile: RUN install.pl ... --without-xpmem --without-xpmem-modules
    Dockerfile->>InstallPl: invoke build-only kernel modules
    InstallPl-->>Dockerfile: RPMS generated (xpmem omitted)
  else Sources container runtime build on SLES
    BuildSystem->>EntrypointSh: build_driver_from_src()
    EntrypointSh->>InstallPl: install.pl ... --kernel-sources ... --without-xpmem --without-xpmem-modules
    InstallPl-->>EntrypointSh: RPMS generated (xpmem omitted)
  else Go entrypoint runtime build on SLES
    BuildSystem->>DriverGo: Build(ctx)
    DriverGo->>DriverGo: getBuildFlagsForOS(SLES)
    DriverGo->>InstallPl: RunCommand(install.pl, ... --without-xpmem --without-xpmem-modules)
    InstallPl-->>DriverGo: build succeeds without xpmem
  end
Loading

Copy link

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

3 files reviewed, no comments

Edit Code Review Agent Settings | Greptile

Signed-off-by: Dana Halperin <dahalperin@nvidia.com>
Copy link

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

4 files reviewed, no comments

Edit Code Review Agent Settings | Greptile

@dahalperin dahalperin merged commit 1e5a0e3 into main Feb 10, 2026
8 checks passed
@dahalperin dahalperin deleted the remove_xpmem branch February 10, 2026 11:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants