Use-after-free and heap-size-mismatch fix.

[strike-kokhotnikov]

Description

1. Removed redundant header dependencies to allow building vlogger and state_machine independently from the rest of the code.
2. Fixed logic of set log color output parameter.
3. Rewrote the functions read_file_to_int (src/vma/util/utils.cpp) and env_to_cpuset (src/vma/util/sys_vars.cpp) to enable running the code with ASAN.
4. Fixed a new/delete size mismatch in src/vma/dev/rfs*.
5. Fixed a use-after-free issue in timer_handler.

What

Use-after-free and heap-size-mismatch fix.

Change type

What kind of change does this PR introduce?

• Bugfix
• Feature
• Code style update
• Refactoring (no functional changes, no api changes)
• Build related changes
• CI related changes
• Documentation content changes
• Tests
• Other

Check list

• Code follows the style de facto guidelines of this project
• Comments have been inserted in hard to understand places
• Documentation has been updated (if necessary)
• Test has been added (if possible)

[svc-nbu-swx-media]

Can one of the admins verify this patch?

[igor-ivanov]

What was wrong with existing assignment?

[strike-kokhotnikov]

Log in color has sense only when logging to tty (see here

libvma/src/vlogger/vlogger.cpp

Line 241 in 0dc96e0

int file_fd = fileno(g_vlogger_file);

, when the output is not tty, than g_vlogger_log_in_colors is not assigned. For file should be false. MCE_DEFAULT_LOG_COLORS properly processed here:

libvma/src/vma/util/sys_vars.cpp

Line 492 in 0dc96e0

log_colors = MCE_DEFAULT_LOG_COLORS;

libvma/src/vma/util/sys_vars.cpp

Line 791 in 0dc96e0

if ((env_ptr = getenv(SYS_VAR_LOG_COLORS)) != NULL)

[igor-ivanov]

accepted

[igor-ivanov]

please consider fixing coding style issue.

[strike-kokhotnikov]

Rebased to latest master and fixed formatting issues.

[AlexanderGrissik]

Please split this PR to separate PRs. One for each mentioned item.
Please also describe in which scenario the issue is observed and how the proposed fix addresses the issue.

[strike-kokhotnikov]

Split to:
#1148
#1149
#1150
#1151