[CI] issue: 4684071Terminate Valgrind gracefully#1141
Open
NirWolfer wants to merge 1 commit intoMellanox:masterfrom
Open
[CI] issue: 4684071Terminate Valgrind gracefully#1141NirWolfer wants to merge 1 commit intoMellanox:masterfrom
NirWolfer wants to merge 1 commit intoMellanox:masterfrom
Conversation
Collaborator
Author
|
bot:retest |
fcc5bdf to
50d4440
Compare
50d4440 to
ec6f093
Compare
Collaborator
Author
|
bot:retest |
Valgrind today is being terminated with -9 which prevents it from printing all the summaries at the end which are needed for debuging. Change -9 signal to -SIGINT af the first try of shutting down Valgrind Signed-off-by: NirWolfer <nwolfer@nvidia.com>
ec6f093 to
b2fd3c5
Compare
Greptile SummaryChanged Valgrind process termination signal from
Confidence Score: 5/5
Important Files Changed
Sequence DiagramsequenceDiagram
participant Script as CI Script
participant Process as Valgrind/sockperf
participant System as Operating System
Script->>Process: Start Valgrind with sockperf server
Script->>Process: Start Valgrind with sockperf client
Script->>Process: Run tests (10 seconds)
alt Process still running
Script->>System: pkill -SIGINT (graceful)
System->>Process: Send SIGINT signal
Process->>Process: Cleanup & print summaries
Process-->>System: Exit gracefully
Script->>Script: Wait 10 seconds
alt SIGINT didn't work
Script->>System: pkill -SIGTERM
System->>Process: Send SIGTERM signal
Process-->>System: Force exit
Script->>Script: Wait 3 seconds
alt SIGTERM didn't work
Script->>System: pkill -SIGKILL
System->>Process: Send SIGKILL signal
Process--xSystem: Immediate termination
end
end
end
Script->>Script: Analyze Valgrind logs
Script->>Script: Report results
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Valgrind today is being terminated with -9 which prevents it from printing all the summaries at the end which are needed for debuging.
What
Change -9 signal to -SIGINT af the first try of shutting down Valgrind
Why ?
HPCINFRA-3989
How ?
It is optional but for complex PRs please provide information about the design,
architecture, approach, etc.
Change type
What kind of change does this PR introduce?
Check list