test: trigger failed network-operator image to test ai-ci analysis [DO-NOT-MERGE]#2149
test: trigger failed network-operator image to test ai-ci analysis [DO-NOT-MERGE]#2149heyvister1 wants to merge 1 commit intoMellanox:masterfrom
Conversation
Signed-off-by: Ido Heyvi <iheyvi@nvidia.com>
Greptile OverviewGreptile SummaryThis PR modifies the Helm chart default values for the Network Operator image in In this repo, those values are consumed by the chart templates to construct the operator deployment image reference. As written, the change will cause chart installs/upgrades using defaults to pull a different image than the operator expects, and is likely to break deployments (which appears intentional for CI analysis given the PR title and DO-NOT-MERGE flag). Confidence Score: 1/5
Important Files Changed
Sequence DiagramsequenceDiagram
participant Dev as PR Author
participant CI as CI Pipeline
participant Reg as Image Registry
participant K8s as Kubernetes Cluster
participant Helm as Helm Release
Dev->>CI: Update values.yaml (operator image ref)
CI->>CI: Build/validate chart values
CI->>Helm: helm template/install
Helm->>K8s: Create/Update Deployment
K8s->>Reg: Pull network-operator image
Reg-->>K8s: 404 / pull error (invalid/failed image)
K8s-->>Helm: Pod ImagePullBackOff
Helm-->>CI: Release unhealthy / install fails
CI-->>Dev: Report failure (ai-ci analysis)
|
| # -- Network Operator image repository. | ||
| repository: nvcr.io/nvstaging/mellanox | ||
| # -- Network Operator image name | ||
| image: network-operator | ||
| image: network-operator-init-container | ||
| # imagePullSecrets: [] | ||
| # -- Name to be used as part of objects name generation. | ||
| nameOverride: "" | ||
| # -- Name to be used to replace generated names. | ||
| fullnameOverride: "" | ||
| # tag, if defined will use the given image tag, else Chart. AppVersion will be used. | ||
| # tag | ||
| tag: network-operator-v26.1.0-beta.6 |
There was a problem hiding this comment.
Breaking default operator image
This changes the default operator image from network-operator to network-operator-init-container and hard-sets operator.tag, which will make the chart deploy a different image than intended and can cause installs/upgrades to fail (e.g., ImagePullBackOff or wrong container entrypoint) in any environment relying on defaults. Since this PR is marked DO-NOT-MERGE and intended to trigger a failure, it should not land on master; at minimum revert these defaults (restore image: network-operator and keep tag commented/unset) before merging.
|
/retest-nic_operator_ci |
|
/retest-all |
No description provided.