Skip to content

test: trigger failed network-operator image to test ai-ci analysis [DO-NOT-MERGE]#2149

Open
heyvister1 wants to merge 1 commit intoMellanox:masterfrom
heyvister1:test-ai-ci-report
Open

test: trigger failed network-operator image to test ai-ci analysis [DO-NOT-MERGE]#2149
heyvister1 wants to merge 1 commit intoMellanox:masterfrom
heyvister1:test-ai-ci-report

Conversation

@heyvister1
Copy link
Collaborator

No description provided.

Signed-off-by: Ido Heyvi <iheyvi@nvidia.com>
@heyvister1 heyvister1 added the on hold This enhancement is currently on hold pending additional clarification and evaluation label Feb 7, 2026
@greptile-apps
Copy link

greptile-apps bot commented Feb 7, 2026

Greptile Overview

Greptile Summary

This PR modifies the Helm chart default values for the Network Operator image in deployment/network-operator/values.yaml, switching the default operator.image and explicitly setting operator.tag.

In this repo, those values are consumed by the chart templates to construct the operator deployment image reference. As written, the change will cause chart installs/upgrades using defaults to pull a different image than the operator expects, and is likely to break deployments (which appears intentional for CI analysis given the PR title and DO-NOT-MERGE flag).

Confidence Score: 1/5

  • This PR is not safe to merge because it intentionally changes chart defaults to a likely-invalid operator image/tag, breaking default installations.
  • Only change in the PR modifies the default operator image name and forces a tag in Helm values, which directly affects runtime image pulls and can lead to Helm release failure in any cluster using defaults. Given the DO-NOT-MERGE intent, this should be reverted before merging to master.
  • deployment/network-operator/values.yaml

Important Files Changed

Filename Overview
deployment/network-operator/values.yaml Changes operator image name and uncomments/sets operator tag, which will force Helm deployments to pull a different (likely invalid) image and can break default chart installs.

Sequence Diagram

sequenceDiagram
  participant Dev as PR Author
  participant CI as CI Pipeline
  participant Reg as Image Registry
  participant K8s as Kubernetes Cluster
  participant Helm as Helm Release

  Dev->>CI: Update values.yaml (operator image ref)
  CI->>CI: Build/validate chart values
  CI->>Helm: helm template/install
  Helm->>K8s: Create/Update Deployment
  K8s->>Reg: Pull network-operator image
  Reg-->>K8s: 404 / pull error (invalid/failed image)
  K8s-->>Helm: Pod ImagePullBackOff
  Helm-->>CI: Release unhealthy / install fails
  CI-->>Dev: Report failure (ai-ci analysis)

Loading

Copy link

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1 file reviewed, 1 comment

Edit Code Review Agent Settings | Greptile

Comment on lines 256 to +266
# -- Network Operator image repository.
repository: nvcr.io/nvstaging/mellanox
# -- Network Operator image name
image: network-operator
image: network-operator-init-container
# imagePullSecrets: []
# -- Name to be used as part of objects name generation.
nameOverride: ""
# -- Name to be used to replace generated names.
fullnameOverride: ""
# tag, if defined will use the given image tag, else Chart. AppVersion will be used.
# tag
tag: network-operator-v26.1.0-beta.6
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Breaking default operator image

This changes the default operator image from network-operator to network-operator-init-container and hard-sets operator.tag, which will make the chart deploy a different image than intended and can cause installs/upgrades to fail (e.g., ImagePullBackOff or wrong container entrypoint) in any environment relying on defaults. Since this PR is marked DO-NOT-MERGE and intended to trigger a failure, it should not land on master; at minimum revert these defaults (restore image: network-operator and keep tag commented/unset) before merging.

@heyvister1
Copy link
Collaborator Author

/retest-nic_operator_ci

@heyvister1
Copy link
Collaborator Author

/retest-all

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

on hold This enhancement is currently on hold pending additional clarification and evaluation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant