Skip to content

ci: update nic-configuration-operator version to 200954e (of branch network-operator-26.1.x)#2155

Open
nvidia-ci-cd wants to merge 1 commit intomasterfrom
ci/update-nic-configuration-operator-version-to-200954e
Open

ci: update nic-configuration-operator version to 200954e (of branch network-operator-26.1.x)#2155
nvidia-ci-cd wants to merge 1 commit intomasterfrom
ci/update-nic-configuration-operator-version-to-200954e

Conversation

@nvidia-ci-cd
Copy link
Collaborator

Automated CI update for component 'nic-configuration-operator', created by GitHub actions reusable workflow run 21858303760 for release branch network-operator-26.1.x.

Signed-off-by: nvidia-ci-cd <svc-cloud-orch-gh@nvidia.com>
@greptile-apps
Copy link

greptile-apps bot commented Feb 10, 2026

Greptile Overview

Greptile Summary

This PR updates the nic-configuration-operator component version reference to 200954e in:

  • hack/release.yaml (used by release/manifest tooling to source image tags), and
  • the two “full” NicClusterPolicy example CRs (OCP + non-OCP).

These updates keep the example CRs aligned with the release config, but introduce a mixed versioning scheme inside hack/release.yaml where the base nic-configuration-operator images use a short SHA while the Stig/FIPS variants remain on network-operator-v26.1.0-beta.6-* tags. If downstream tooling assumes a consistent tag scheme for all variants of a component, this will break only those two images’ resolution/promotion/pull paths.

Confidence Score: 3/5

  • Merge is moderate risk until the release/versioning scheme inconsistency is confirmed or corrected.
  • Change is small and limited to YAML version strings, but it switches two nic-configuration-operator images from a release tag format to a short SHA while other variants remain on release-tag naming; if release tooling expects consistent version semantics, it will fail deterministically for those images.
  • hack/release.yaml (and any tooling consuming it for image/tag resolution)

Important Files Changed

Filename Overview
example/crs/mellanox.com_v1alpha1_nicclusterpolicy_cr-full-ocp.yaml Updates nic-configuration-operator/operator-daemon versions in the OCP full NicClusterPolicy example from network-operator-v26.1.0-beta.6 to 200954e.
example/crs/mellanox.com_v1alpha1_nicclusterpolicy_cr-full.yaml Updates nic-configuration-operator/operator-daemon versions in the full NicClusterPolicy example from network-operator-v26.1.0-beta.6 to 200954e.
hack/release.yaml Bumps nic-configuration-operator and its config-daemon version fields to 200954e; other variants remain on network-operator-v26.1.0-beta.6-* tags.

Sequence Diagram

sequenceDiagram
    autonumber
    participant Rel as hack/release.yaml
    participant Build as CI build/publish (nic-configuration-operator)
    participant Gen as Release tooling (manifests/examples)
    participant User as Cluster admin
    participant K8s as Kubernetes

    Rel->>Gen: Version set to 200954e
    Gen->>Build: Resolve image tag/digest for nic-configuration-operator
    Build-->>Gen: Publish/tag image (expected tag exists)
    Gen-->>User: Generate example CRs/values referencing version
    User->>K8s: Apply NicClusterPolicy example
    K8s->>K8s: Pull operator + daemon images by tag
    Note over Gen,K8s: If tag format mismatches expected scheme,
    Note over Gen,K8s: resolution/promotion/pull can fail for these images only
Loading

Copy link

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

3 files reviewed, 1 comment

Edit Code Review Agent Settings | Greptile

@greptile-apps
Copy link

greptile-apps bot commented Feb 10, 2026

Additional Comments (1)

hack/release.yaml
Inconsistent version semantics

nicConfigurationOperator.version / nicConfigurationConfigDaemon.version are switched from a release tag (network-operator-v26.1.0-beta.6) to a short SHA (200954e), while the other nic-configuration-operator variants in the same file (e.g. nicConfigurationOperatorStigFips*) still use the release-tag naming. If the tooling that consumes hack/release.yaml expects a consistent tag format per component/release (e.g., for mirroring, signing, or manifest generation), this mismatch will break lookup/promotion for only these two images. Please either update the corresponding Stig/FIPS entries to the same versioning scheme or keep these two on the release tag scheme for consistency.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant