Skip to content

ci: update Spectrum-X Operator STIG components (Ubuntu: 92071f3-ubuntu, RHEL: 92071f3-rhel)#2183

Open
nvidia-ci-cd wants to merge 1 commit intomasterfrom
ci/update-spectrum-x-operator-stig-fips-versions-to-ae51473b
Open

ci: update Spectrum-X Operator STIG components (Ubuntu: 92071f3-ubuntu, RHEL: 92071f3-rhel)#2183
nvidia-ci-cd wants to merge 1 commit intomasterfrom
ci/update-spectrum-x-operator-stig-fips-versions-to-ae51473b

Conversation

@nvidia-ci-cd
Copy link
Collaborator

Automated CI update for components 'spectrumXOperatorStigFipsUbuntu' and 'spectrumXOperatorStigFipsRhel', created by internal GitLab CI for release branch network-operator-26.1.x.

…92071f3-rhel

Signed-off-by: nvidia-ci-cd <svc-cloud-orch-gh@nvidia.com>
@greptile-apps
Copy link

greptile-apps bot commented Feb 15, 2026

Greptile Summary

Updated Spectrum-X Operator STIG component versions for Ubuntu and RHEL variants from semantic versioning format to commit hash format.

  • Changed spectrumXOperatorStigFipsRhel version from network-operator-v26.1.0-beta.7-stig-fips-rhel to 92071f3-rhel
  • Changed spectrumXOperatorStigFipsUbuntu version from network-operator-v26.1.0-beta.7-stig-fips-ubuntu to 92071f3-ubuntu

Key Concerns:

  • Version format breaks established pattern - all 40+ other components in hack/release.yaml use network-operator-v* or doca* semantic versioning
  • The release workflow (.github/workflows/release.yaml:174,261) constructs component tags using ${COMPONENT_TAG}-stig-fips-${component_flavor} logic, which may not work correctly with commit hash versions
  • These are the only two components in the entire file using short commit hash format, creating inconsistency

Confidence Score: 2/5

  • This PR introduces a potentially breaking change in version format that deviates from all other components
  • The change introduces a fundamentally different versioning approach (commit hashes vs semantic versions) for these two STIG components, which is inconsistent with 40+ other components. The release workflow logic may not handle this correctly, and there's no explanation for why these components need a different format.
  • hack/release.yaml requires verification that the version format change is compatible with automated release workflows

Important Files Changed

Filename Overview
hack/release.yaml Updates Spectrum-X Operator STIG component versions from semantic version format to commit hash format (92071f3-ubuntu/rhel)

Last reviewed commit: 49184ae

Copy link

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1 file reviewed, 2 comments

Edit Code Review Agent Settings | Greptile

repository: nvcr.io/nvstaging/mellanox
sourceRepository: spectrum-x-operator
version: network-operator-v26.1.0-beta.7-stig-fips-rhel
version: 92071f3-rhel
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Version format changed from semantic versioning (network-operator-v26.1.0-beta.7-stig-fips-rhel) to short commit hash (92071f3-rhel). This breaks the established pattern where all other components use network-operator-v* prefixed versions. Verify this is intentional and won't break the release workflow logic that constructs tags like ${COMPONENT_TAG}-stig-fips-${component_flavor} (see .github/workflows/release.yaml:174 and :261).

repository: nvcr.io/nvstaging/mellanox
sourceRepository: spectrum-x-operator
version: network-operator-v26.1.0-beta.7-stig-fips-ubuntu
version: 92071f3-ubuntu
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same version format inconsistency as RHEL variant - using commit hash 92071f3-ubuntu instead of network-operator-v26.1.0-beta.7-stig-fips-ubuntu pattern used by all other components.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant