Skip to content

release fix: install needed deps for MFT in operator rhel-stig#251

Merged
almaslennikov merged 2 commits intonetwork-operator-26.1.xfrom
main
Jan 28, 2026
Merged

release fix: install needed deps for MFT in operator rhel-stig#251
almaslennikov merged 2 commits intonetwork-operator-26.1.xfrom
main

Conversation

@almaslennikov
Copy link
Collaborator

No description provided.

Signed-off-by: Alexander Maslennikov <amaslennikov@nvidia.com>
fix: install needed deps for MFT in operator rhel-stig
@almaslennikov almaslennikov merged commit 581c501 into network-operator-26.1.x Jan 28, 2026
9 checks passed
@greptile-apps
Copy link

greptile-apps bot commented Jan 28, 2026

Greptile Overview

Greptile Summary

This PR optimizes the MFT (Mellanox Firmware Tools) installation in the RHEL STIG operator dockerfile by removing redundant package installations and adding the required kmod dependency. The changes include:

  • Removed dnf makecache which is unnecessary before a simple install operation
  • Removed explicit curl installation since curl-minimal is already available in the UBI base image
  • Added kmod package installation which is required by MFT's install script

The changes align with the existing pattern used in Dockerfile.daemon.stig-rhel where curl is used without explicit installation. This reduces image build time and size while ensuring MFT installs correctly.

Confidence Score: 5/5

  • This PR is safe to merge - it fixes missing dependencies and optimizes the build process
  • The changes are minimal, well-documented, and follow established patterns from other dockerfiles in the repository. The fix addresses a real dependency requirement (kmod for MFT) while removing redundant steps (dnf makecache, explicit curl installation)
  • No files require special attention

Important Files Changed

Filename Overview
Dockerfile.operator.stig-rhel Removed redundant curl installation and dnf makecache, added required kmod dependency for MFT installation

Sequence Diagram

sequenceDiagram
    participant Build as Build Stage (golang:1.24)
    participant Base as RHEL STIG Base Image
    participant DNF as DNF Package Manager
    participant MFT as MFT Installer
    participant Container as Final Container
    
    Build->>Build: Compile manager binary
    Note over Base: Start RHEL STIG runtime stage
    Base->>DNF: Install kmod package
    Note over DNF: kmod required by MFT
    DNF-->>Base: kmod installed
    Base->>Base: Download MFT tarball via curl
    Note over Base: curl-minimal from base image
    Base->>MFT: Extract and run install.sh --without-kernel
    MFT->>MFT: Install MFT tools (requires kmod)
    MFT-->>Base: MFT installation complete
    Base->>Base: Cleanup temporary files
    Build->>Container: Copy manager binary
    Container->>Container: Run as user 65532:65532
Loading

Copy link

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1 file reviewed, no comments

Edit Code Review Agent Settings | Greptile

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant