fix: use mlxconfig to set LINK TYPE P1#279
Merged
almaslennikov merged 1 commit intonetwork-operator-26.1.xfrom Feb 10, 2026
Merged
fix: use mlxconfig to set LINK TYPE P1#279almaslennikov merged 1 commit intonetwork-operator-26.1.xfrom
almaslennikov merged 1 commit intonetwork-operator-26.1.xfrom
Conversation
LINK_TYPE_P2 is not available on CX8 so DMS breaks on this command Signed-off-by: Alexander Maslennikov <amaslennikov@nvidia.com>
Greptile OverviewGreptile SummaryThis PR updates the Spectrum-X reference configs (RA1.3/RA2.0/RA2.1) to set Ethernet mode via I didn’t find any must-fix issues in the changes themselves: the Spectrum-X config loader expects Confidence Score: 5/5
Important Files Changed
Sequence DiagramsequenceDiagram
participant Reconciler as SpectrumXConfigManager
participant Loader as LoadSpectrumXConfig(YAML)
participant Splitter as getNvConfigParameters
participant NV as nvConfigUtils (mlxconfig)
participant DMS as DMS Client
Reconciler->>Loader: Read bindata/spectrum-x/RA*.yaml
Loader-->>Reconciler: SpectrumXConfig (nvConfig params)
Reconciler->>Splitter: Separate nvConfig into mlxconfig vs dmsPath
Splitter-->>Reconciler: mlxconfigParams, dmsParams
Note over Reconciler,NV: This PR moves "Ethernet mode" to mlxconfig
Reconciler->>NV: SetNvConfigParameter(LINK_TYPE_P1, "2")
NV-->>Reconciler: ok / error
alt other DMS-based parameters present
Reconciler->>DMS: SetParameters(dmsPath, valueType, value)
DMS-->>Reconciler: ok / error
end
Reconciler->>NV: QueryNvConfig(LINK_TYPE_P1)
NV-->>Reconciler: CurrentConfig includes "2" => applied
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
LINK_TYPE_P2 is not available on CX8 so DMS breaks on this command