Skip to content

fix: use mlxconfig to set LINK TYPE P1#279

Merged
almaslennikov merged 1 commit intonetwork-operator-26.1.xfrom
use-mlxconfig-for-link-type-release
Feb 10, 2026
Merged

fix: use mlxconfig to set LINK TYPE P1#279
almaslennikov merged 1 commit intonetwork-operator-26.1.xfrom
use-mlxconfig-for-link-type-release

Conversation

@almaslennikov
Copy link
Collaborator

LINK_TYPE_P2 is not available on CX8 so DMS breaks on this command

LINK_TYPE_P2 is not available on CX8 so DMS breaks on this command

Signed-off-by: Alexander Maslennikov <amaslennikov@nvidia.com>
@almaslennikov almaslennikov merged commit 10ec20b into network-operator-26.1.x Feb 10, 2026
5 checks passed
@almaslennikov almaslennikov deleted the use-mlxconfig-for-link-type-release branch February 10, 2026 12:26
@greptile-apps
Copy link

greptile-apps bot commented Feb 10, 2026

Greptile Overview

Greptile Summary

This PR updates the Spectrum-X reference configs (RA1.3/RA2.0/RA2.1) to set Ethernet mode via mlxconfig instead of DMS, using LINK_TYPE_P1=2 (Ethernet). This aligns with the operator’s Spectrum-X config application flow (nvConfig entries are split into mlxconfig vs DMS parameters) and avoids relying on LINK_TYPE_P2, which is not available on CX8 per the PR description.

I didn’t find any must-fix issues in the changes themselves: the Spectrum-X config loader expects ConfigurationParameter.Value as a string, and YAML numeric scalars like 2 will be unmarshaled to the string field as "2", so the mlxconfig apply/check paths should work as intended.

Confidence Score: 5/5

  • This PR is safe to merge with minimal risk.
  • Changes are limited to bindata Spectrum-X YAML templates and switch Ethernet mode to an existing, well-supported nvconfig parameter (LINK_TYPE_P1) with the correct numeric value for Ethernet. Repo code supports mlxconfig-only parameters and explicitly tolerates absence of LINK_TYPE_P2 on dual-port devices when it’s not available.
  • No files require special attention

Important Files Changed

Filename Overview
bindata/spectrum-x/RA1.3.yaml Switch 'Ethernet mode' from DMS interface type to mlxconfig LINK_TYPE_P1=2 (Ethernet); rest unchanged.
bindata/spectrum-x/RA2.0.yaml Switch 'Ethernet mode' from DMS interface type to mlxconfig LINK_TYPE_P1=2 (Ethernet); rest unchanged.
bindata/spectrum-x/RA2.1.yaml Switch 'Ethernet mode' from DMS interface type to mlxconfig LINK_TYPE_P1=2 (Ethernet) in nvConfig; rest unchanged.

Sequence Diagram

sequenceDiagram
    participant Reconciler as SpectrumXConfigManager
    participant Loader as LoadSpectrumXConfig(YAML)
    participant Splitter as getNvConfigParameters
    participant NV as nvConfigUtils (mlxconfig)
    participant DMS as DMS Client

    Reconciler->>Loader: Read bindata/spectrum-x/RA*.yaml
    Loader-->>Reconciler: SpectrumXConfig (nvConfig params)
    Reconciler->>Splitter: Separate nvConfig into mlxconfig vs dmsPath
    Splitter-->>Reconciler: mlxconfigParams, dmsParams

    Note over Reconciler,NV: This PR moves "Ethernet mode" to mlxconfig
    Reconciler->>NV: SetNvConfigParameter(LINK_TYPE_P1, "2")
    NV-->>Reconciler: ok / error

    alt other DMS-based parameters present
        Reconciler->>DMS: SetParameters(dmsPath, valueType, value)
        DMS-->>Reconciler: ok / error
    end

    Reconciler->>NV: QueryNvConfig(LINK_TYPE_P1)
    NV-->>Reconciler: CurrentConfig includes "2" => applied
Loading

Copy link

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

3 files reviewed, no comments

Edit Code Review Agent Settings | Greptile

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant