Skip to content

fix: add procps-ng package to RHEL STIG daemon image for QoS configur…#294

Merged
almaslennikov merged 1 commit intoMellanox:mainfrom
rollandf:fix-qos
Feb 16, 2026
Merged

fix: add procps-ng package to RHEL STIG daemon image for QoS configur…#294
almaslennikov merged 1 commit intoMellanox:mainfrom
rollandf:fix-qos

Conversation

@rollandf
Copy link
Member

…ation

The DMS service uses /usr/bin/mlnx_qos to handle QoS configuration (trust mode and PFC settings). The mlnx_qos Python script internally depends on the 'ps' command to check running processes.

The STIG-hardened RHEL images strip out procps-ng for security hardening, causing QoS configuration to fail with:
FileNotFoundError: [Errno 2] No such file or directory: 'ps'

This results in NicDevice runtime configuration failures with the error: "failed to get trust mode: failed to run get path command: exit status 1"

Add procps-ng to the nic-configuration-daemon STIG RHEL image to resolve this dependency. The Ubuntu STIG images already include procps and are not affected.

…ation

The DMS service uses /usr/bin/mlnx_qos to handle QoS configuration
(trust mode and PFC settings). The mlnx_qos Python script internally
depends on the 'ps' command to check running processes.

The STIG-hardened RHEL images strip out procps-ng for security
hardening, causing QoS configuration to fail with:
  FileNotFoundError: [Errno 2] No such file or directory: 'ps'

This results in NicDevice runtime configuration failures with the
error: "failed to get trust mode: failed to run get path command:
exit status 1"

Add procps-ng to the nic-configuration-daemon STIG RHEL image to
resolve this dependency. The Ubuntu STIG images already include
procps and are not affected.

Signed-off-by: Fred Rolland <frolland@nvidia.com>
@greptile-apps
Copy link

greptile-apps bot commented Feb 15, 2026

Greptile Summary

Added procps-ng package to RHEL STIG daemon image to fix QoS configuration failures. The DMS service uses /usr/bin/mlnx_qos Python script (added in commit fbfe19c) which internally depends on the ps command to check running processes. STIG-hardened RHEL images strip out procps-ng by default for security hardening, causing QoS configuration to fail with FileNotFoundError.

  • Fixes runtime configuration failures for trust mode and PFC settings
  • Change is minimal, targeted, and necessary for functionality
  • Ubuntu STIG images unaffected (already include procps by default)
  • Aligns daemon image dependencies with operational requirements

Confidence Score: 5/5

  • This PR is safe to merge with minimal risk
  • The change is a single-line addition to install a standard system utility package (procps-ng) that provides the ps command. This is a necessary dependency for the mlnx_qos script that was recently added to handle QoS configuration. The fix is well-documented, targeted, and addresses a clear runtime failure. No code logic changes, no security concerns with adding this widely-used system monitoring package.
  • No files require special attention

Important Files Changed

Filename Overview
Dockerfile.daemon.stig-rhel Added procps-ng package to fix QoS configuration dependency on ps command

Last reviewed commit: 1407279

Copy link

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1 file reviewed, no comments

Edit Code Review Agent Settings | Greptile

@almaslennikov almaslennikov merged commit 2052731 into Mellanox:main Feb 16, 2026
9 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants