chore: support 'imagePullSecrets' propagation#8
chore: support 'imagePullSecrets' propagation#8heyvister1 wants to merge 1 commit intoMellanox:masterfrom
Conversation
dd28c75 to
6bd7295
Compare
Signed-off-by: Ido Heyvi <iheyvi@nvidia.com>
e0ne
left a comment
There was a problem hiding this comment.
Why should we do this? we can propagate imagePullSecrets for this chart like we do for sriov operator in NVIDIA Network Operator project
The motivation was to refrain of declaring |
I really don't like the idea to change upstream API |
I can suggest this fix for upstream |
|
id suggest to do the opposite. having this skew is not good practice. i.e suggest changes upstream and let them be synced back to this fork. |
|
I agree with @adrianchiris. I think that we should go with the same approach that we have for the SR-IOV operator for now and let's try to push this PR upstream first before doing any changes in the fork. |
|
Will wait until this change is merged by kubernetes-sigs#2191 |
Added
imagePullSecretspropagation helper function, to support the following options:Values.imagePullSecrets.Values.global.imagePullSecrets