Skip to content

feat: update image tagging logic in GH workflows #21

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
hareeshpc wants to merge 1 commit into
base: main
Choose a base branch
from
Open

feat: update image tagging logic in GH workflows #21

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 9 additions & 3 deletions .github/workflows/build-images.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,8 +36,10 @@ jobs:
run: |
if [[ "${{ github.ref }}" == refs/tags/* ]]; then
TAG=${GITHUB_REF#refs/tags/}
elif [[ "${{ github.event_name }}" == "push" ]]; then
TAG=v0.1.0-latest
else
TAG=v25.7.1-${GITHUB_SHA::7}
TAG=v0.1.0-${GITHUB_SHA::8}-test
fi
echo "tag=${TAG}" >> $GITHUB_OUTPUT

Expand Down Expand Up @@ -95,8 +97,10 @@ jobs:
run: |
if [[ "${{ github.ref }}" == refs/tags/* ]]; then
TAG=${GITHUB_REF#refs/tags/}
elif [[ "${{ github.event_name }}" == "push" ]]; then
TAG=v0.1.0-latest
else
TAG=v25.7.1-${GITHUB_SHA::7}
TAG=v0.1.0-${GITHUB_SHA::8}-test
fi
echo "tag=${TAG}" >> $GITHUB_OUTPUT

Expand Down Expand Up @@ -154,8 +158,10 @@ jobs:
run: |
if [[ "${{ github.ref }}" == refs/tags/* ]]; then
TAG=${GITHUB_REF#refs/tags/}
elif [[ "${{ github.event_name }}" == "push" ]]; then
TAG=v0.1.0-latest
else
TAG=v25.7.1-${GITHUB_SHA::7}
TAG=v0.1.0-${GITHUB_SHA::8}-test
fi
echo "tag=${TAG}" >> $GITHUB_OUTPUT

Expand Down
11 changes: 3 additions & 8 deletions .github/workflows/publish-helm.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,23 +43,18 @@ jobs:
run: |
if [[ "${{ github.ref }}" == refs/tags/* ]]; then
TAG=${GITHUB_REF#refs/tags/}
elif [[ "${{ github.event_name }}" == "push" ]]; then
TAG=v0.1.0-latest
else
TAG=v25.7.1-${GITHUB_SHA::7}
TAG=v0.1.0-${GITHUB_SHA::8}-test
fi
echo "tag=${TAG}" >> $GITHUB_OUTPUT

- name: Log in to Container Registry
if: github.event_name != 'pull_request'
run: |
echo "${{ secrets.GITHUB_TOKEN }}" | helm registry login ${{ env.REGISTRY }} --username ${{ github.actor }} --password-stdin

- name: Build Helm chart
if: github.event_name == 'pull_request'
run: |
make helm-build TAG=${{ steps.tag.outputs.tag }} REGISTRY=ghcr.io/mellanox

- name: Build and publish Helm chart
if: github.event_name != 'pull_request'
run: |
make helm-publish TAG=${{ steps.tag.outputs.tag }} REGISTRY=ghcr.io/mellanox

Loading