Skip to content

fix: drop webhook in favor of mutatingAdmissionPolicy#9

Merged
killianmuldoon merged 1 commit intoMellanox:mainfrom
killianmuldoon:pr-simplify-injector
Dec 9, 2025
Merged

fix: drop webhook in favor of mutatingAdmissionPolicy#9
killianmuldoon merged 1 commit intoMellanox:mainfrom
killianmuldoon:pr-simplify-injector

Conversation

@killianmuldoon
Copy link
Collaborator

simplify the webhook code to enable it to inject almost all pods

exclude host network pods using matchConditions in the mutatingadmission spec

@killianmuldoon killianmuldoon force-pushed the pr-simplify-injector branch 4 times, most recently from 944079c to 4483acc Compare December 8, 2025 17:55
@killianmuldoon killianmuldoon changed the title fix: simplify webhook to inject all pods fix: drop webhook in favor of mutatingAdmissionPolicy Dec 8, 2025
@killianmuldoon killianmuldoon force-pushed the pr-simplify-injector branch 2 times, most recently from 39d0530 to 0b61007 Compare December 8, 2025 18:02
@aserdean aserdean self-requested a review December 9, 2025 08:18
Copy link
Collaborator

@aserdean aserdean left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor nits, rest LGTM

@killianmuldoon killianmuldoon force-pushed the pr-simplify-injector branch 2 times, most recently from dc044ba to 5f0b94b Compare December 9, 2025 12:00
- Add MutatingAdmissionPolicy and MutatingAdmissionPolicyBinding templates
- Remove webhook-based resource injector (deployment, RBAC, certificates)
- Add envtest-based tests for admission policy
- Update Makefile with test helpers (TESTPKG, TESTARGS, helm install)
- Simplify values.yaml to just enabled and resourceName options
@killianmuldoon killianmuldoon merged commit a2158e7 into Mellanox:main Dec 9, 2025
6 checks passed
killianmuldoon added a commit that referenced this pull request Dec 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants