Skip to content

fix: improve check for sriov result file in systemd mode#101

Merged
e0ne merged 1 commit intoMellanox:network-operator-25.10.xfrom
almaslennikov:systemd-mode-result-exists-fix
Nov 19, 2025
Merged

fix: improve check for sriov result file in systemd mode#101
e0ne merged 1 commit intoMellanox:network-operator-25.10.xfrom
almaslennikov:systemd-mode-result-exists-fix

Conversation

@almaslennikov
Copy link
Collaborator

If the result file doesn't exist but the systemd service is enabled, the sriovResultExists == true.
Fix this logic by checking if the result actually exists

If the result file doesn't exist but the systemd service is enabled,
the sriovResultExists == true.
Fix this logic by checking if the result actually exists

Signed-off-by: Alexander Maslennikov <amaslennikov@nvidia.com>
@github-actions
Copy link

Thanks for your PR,
To run vendors CIs, Maintainers can use one of:

  • /test-all: To run all tests for all vendors.
  • /test-e2e-all: To run all E2E tests for all vendors.
  • /test-e2e-nvidia-all: To run all E2E tests for NVIDIA vendor.

To skip the vendors CIs, Maintainers can use one of:

  • /skip-all: To skip all tests for all vendors.
  • /skip-e2e-all: To skip all E2E tests for all vendors.
  • /skip-e2e-nvidia-all: To skip all E2E tests for NVIDIA vendor.
    Best regards.

@coveralls
Copy link

Pull Request Test Coverage Report for Build 19470613814

Details

  • 0 of 1 (0.0%) changed or added relevant line in 1 file are covered.
  • 6 unchanged lines in 2 files lost coverage.
  • Overall coverage decreased (-0.007%) to 62.007%

Changes Missing Coverage Covered Lines Changed/Added Lines %
pkg/daemon/daemon.go 0 1 0.0%
Files with Coverage Reduction New Missed Lines %
pkg/daemon/daemon.go 2 47.42%
controllers/sriovnetworknodepolicy_controller.go 4 60.69%
Totals Coverage Status
Change from base Build 19225323092: -0.007%
Covered Lines: 8800
Relevant Lines: 14192

💛 - Coveralls

Copy link
Collaborator

@heyvister1 heyvister1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@e0ne e0ne merged commit 2bfe556 into Mellanox:network-operator-25.10.x Nov 19, 2025
11 of 13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants