fix: reboot loop and improve devlink parameter reconciliation#134
Merged
e0ne merged 1 commit intoMellanox:network-operator-26.1.xfrom Jan 19, 2026
Merged
fix: reboot loop and improve devlink parameter reconciliation#134e0ne merged 1 commit intoMellanox:network-operator-26.1.xfrom
e0ne merged 1 commit intoMellanox:network-operator-26.1.xfrom
Conversation
Member
rollandf
commented
Jan 18, 2026
rollandf
commented
- Avoid unnecessary reboots by checking Mellanox firmware multiport state.
- Ensure devlink parameter changes trigger interface reconciliation.
- Avoid unnecessary reboots by checking Mellanox firmware multiport state. - Ensure devlink parameter changes trigger interface reconciliation. Signed-off-by: Fred Rolland <frolland@nvidia.com>
|
Thanks for your PR,
To skip the vendors CIs, Maintainers can use one of:
|
Greptile SummaryThis PR fixes the Mellanox firmware reboot loop issue and ensures devlink parameter changes trigger proper interface reconciliation. Key Changes
Confidence Score: 4/5
Important Files Changed
Sequence DiagramsequenceDiagram
participant Plugin as MellanoxPlugin
participant Helper as api/v1/helper
participant Vendor as mellanox/mlxutils
participant FW as Firmware (mstconfig)
Note over Plugin: OnNodeStateChange()
Plugin->>Vendor: GetMlxNicFwData(pciAddress)
Vendor->>FW: MstConfigReadData()
FW-->>Vendor: Current & Next FW data (including LagResourceAllocation)
Vendor->>Vendor: mlnxNicFromMap()
Note over Vendor: Parse LagResourceAllocation<br/>Set Multiport: -1 if unsupported<br/>Set Multiport: 0 or 1 if supported
Vendor-->>Plugin: fwCurrent, fwNext
Plugin->>Vendor: HandleESwitchParams(pciPrefix, attrs, fwCurrent, specs, status)
Vendor->>Vendor: isESwitchParamsRequireChange(spec, status)
Note over Vendor: Check if esw_multiport<br/>param requested
alt Multiport change needed
alt fwCurrent.Multiport == -1
Note over Vendor: LagResourceAllocation not supported<br/>Skip firmware change
Vendor-->>Plugin: needReboot = false
else fwCurrent.Multiport == desiredMultiport
Note over Vendor: Already set in firmware<br/>Skip reboot
Vendor-->>Plugin: needReboot = false
else Multiport needs change
Note over Vendor: Set attrs.Multiport to desired value
Vendor-->>Plugin: needReboot = true
end
else No change needed
Vendor-->>Plugin: needReboot = false
end
Plugin->>Helper: NeedToUpdateSriov(ifaceSpec, ifaceStatus)
Helper->>Helper: NeedToUpdateDevlinkParams(desired, current)
Note over Helper: Compare each devlink param<br/>Check name and value match
Helper-->>Plugin: true if devlink params differ
alt needReboot == true
Plugin->>Vendor: MlxConfigFW(attributesToChange)
Vendor->>FW: mstconfig set LAG_RESOURCE_ALLOCATION=X
Plugin->>Vendor: MlxResetFW(pciAddresses)
Vendor->>FW: mstfwreset --skip_driver
Note over Plugin: Node will reboot
end
|
Member
Author
|
Policy used: apiVersion: sriovnetwork.openshift.io/v1
kind: SriovNetworkNodePolicy
metadata:
name: rail-0
namespace: network-operator
spec:
bridge:
groupingPolicy: all
ovs:
bridge:
datapathType: netdev
failMode: secure
uplink:
interface:
mtuRequest: 1500
type: dpdk
deviceType: netdevice
devlinkParams:
params:
- applyOn: PF
cmode: runtime
name: esw_multiport
value: "true"
eSwitchMode: switchdev
isRdma: true
linkType: ETH
mtu: 1500
nicSelector:
pfNames:
- eth_p0_r0
nodeSelector:
node-role.kubernetes.io/worker: ""
numVfs: 1
priority: 99
resourceName: rail_0 |
Member
Author
|
Failing log: |
rollandf
changed the title
e0ne
approved these changes
Jan 19, 2026
e0ne
merged commit 94dfa2a
into
Mellanox:network-operator-26.1.x
11 of 14 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.