Skip to content

feat: go proxy for STIG SRIOV config daemon CI via group level variable#140

Merged
maze88 merged 1 commit intoMellanox:masterfrom
maze88:oidc-go-proxy
Jan 22, 2026
Merged

feat: go proxy for STIG SRIOV config daemon CI via group level variable#140
maze88 merged 1 commit intoMellanox:masterfrom
maze88:oidc-go-proxy

Conversation

@maze88
Copy link
Collaborator

@maze88 maze88 commented Jan 21, 2026

No description provided.

@maze88 maze88 requested review from e0ne and rollandf January 21, 2026 13:32
@github-actions
Copy link

Thanks for your PR,
To run vendors CIs, Maintainers can use one of:

  • /test-all: To run all tests for all vendors.
  • /test-e2e-all: To run all E2E tests for all vendors.
  • /test-e2e-nvidia-all: To run all E2E tests for NVIDIA vendor.

To skip the vendors CIs, Maintainers can use one of:

  • /skip-all: To skip all tests for all vendors.
  • /skip-e2e-all: To skip all E2E tests for all vendors.
  • /skip-e2e-nvidia-all: To skip all E2E tests for NVIDIA vendor.
    Best regards.

@greptile-apps
Copy link

greptile-apps bot commented Jan 21, 2026

Greptile Summary

Added GOPROXY as a build argument for the STIG SRIOV config daemon Docker build, enabling configurable Go module proxy for dependency management.

  • Added GOPROXY to the validation list of required GitLab group variables (line 58)
  • Passed GOPROXY as a build argument to the docker build command (line 117)
  • Updated comments for clarity: "are defined" instead of "defined" and improved variable validation comment
  • Removed unnecessary quotes from DOCKER_TLS_CERTDIR value (cosmetic change)

The change integrates with the existing Dockerfile which already accepts GOPROXY as an ARG and sets it as an ENV variable for the Go build process. This allows organizations to use private or cached Go proxy servers during the build.

Confidence Score: 5/5

  • This PR is safe to merge with minimal risk
  • The changes are straightforward and low-risk: adding a new environment variable to an existing validation list and passing it as a build argument. The Dockerfile already supports GOPROXY, so this simply enables its configuration via CI. The variable validation ensures the pipeline will fail early if GOPROXY is not set, preventing silent failures during builds.
  • No files require special attention

Important Files Changed

Filename Overview
.gitlab-ci.yml Added GOPROXY variable validation and build argument with minor comment improvements

Sequence Diagram

sequenceDiagram
    participant CI as GitLab CI
    participant Vars as Group Variables
    participant Docker as Docker Build
    participant Registry as Container Registry
    participant Go as Go Build
    
    Note over CI,Vars: Pipeline Triggered on network-operator-* branch/tag
    
    CI->>Vars: Fetch GOPROXY variable
    CI->>CI: Validate GOPROXY is set
    alt GOPROXY not set
        CI->>CI: Exit with error
    end
    
    CI->>Docker: Authenticate to registries
    CI->>CI: Clone STIG scripts
    CI->>CI: Setup policy documents (if tag)
    
    CI->>Docker: docker build with GOPROXY arg
    Docker->>Go: Pass GOPROXY as ENV
    Go->>Go: Use GOPROXY for dependency downloads
    Go->>Docker: Build sriov-network-config-daemon
    Docker->>Registry: Push STIG-FIPS image
    
    Note over CI,Registry: Image ready for scanning and deployment
Loading

Signed-off-by: Michael Zeevi <mzeevi@nvidia.com>
@maze88 maze88 changed the title feat: go proxy for STIG DOCA CI via group level variable feat: go proxy for STIG SRIOV config daemon CI via group level variable Jan 21, 2026
@maze88 maze88 requested a review from almaslennikov January 21, 2026 16:54
@maze88 maze88 merged commit b8c5c5c into Mellanox:master Jan 22, 2026
12 of 16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants