Skip to content

fix; ignore git dir on non current dir#151

Merged
rollandf merged 1 commit intoMellanox:network-operator-26.1.xfrom
rollandf:gitignore
Feb 10, 2026
Merged

fix; ignore git dir on non current dir#151
rollandf merged 1 commit intoMellanox:network-operator-26.1.xfrom
rollandf:gitignore

Conversation

@rollandf
Copy link
Member

No description provided.

Signed-off-by: Fred Rolland <frolland@nvidia.com>
@github-actions
Copy link

Thanks for your PR,
To run vendors CIs, Maintainers can use one of:

  • /test-all: To run all tests for all vendors.
  • /test-e2e-all: To run all E2E tests for all vendors.
  • /test-e2e-nvidia-all: To run all E2E tests for NVIDIA vendor.

To skip the vendors CIs, Maintainers can use one of:

  • /skip-all: To skip all tests for all vendors.
  • /skip-e2e-all: To skip all E2E tests for all vendors.
  • /skip-e2e-nvidia-all: To skip all E2E tests for NVIDIA vendor.
    Best regards.

@rollandf rollandf merged commit d8293c2 into Mellanox:network-operator-26.1.x Feb 10, 2026
10 of 11 checks passed
@greptile-apps
Copy link

greptile-apps bot commented Feb 10, 2026

Greptile Overview

Greptile Summary

This PR adjusts the Docker build context filtering by changing the .dockerignore rule from **/.git to **/*/.git, aiming to ignore .git directories when they appear under subdirectories rather than only at the context root.

The change affects how docker build packages the repository into the build context; excluding nested .git directories can reduce context size and prevent leaking VCS metadata into image builds.

Confidence Score: 5/5

  • This PR is safe to merge with minimal risk.
  • The change is a one-line .dockerignore pattern update scoped to Docker build context inclusion, with no impact on runtime code paths. No functional regressions were identified in repository build workflows from this change alone.
  • No files require special attention

Important Files Changed

Filename Overview
.dockerignore Updates the .dockerignore pattern from **/.git to **/*/.git to ignore nested .git directories during Docker builds.

Sequence Diagram

sequenceDiagram
    participant Docker as docker build
    participant Ctx as Build context
    participant Ignore as .dockerignore

    Docker->>Ctx: Read build context root
    Docker->>Ignore: Load ignore patterns
    Ignore-->>Docker: Patterns include `**/*/.git`
    Docker->>Ctx: Walk files/dirs for context
    Docker-->>Ctx: Exclude any path matching `**/*/.git`
    Docker->>Docker: Send filtered context to builder
Loading

Copy link

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1 file reviewed, no comments

Edit Code Review Agent Settings | Greptile

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants