Make ovs-vswitchd service 'other_config' option configurable#58
Make ovs-vswitchd service 'other_config' option configurable#58e0ne merged 2 commits intoMellanox:network-operator-25.4.xfrom
Conversation
Signed-off-by: Ivan Kolodiazhnyi <ikolodiazhny@nvidia.com>
Signed-off-by: Ivan Kolodiazhnyi <ikolodiazhny@nvidia.com>
|
Thanks for your PR,
To skip the vendors CIs, Maintainers can use one of:
|
| //RDMA subsystem. Allowed value "shared", "exclusive". | ||
| RdmaMode string `json:"rdmaMode,omitempty"` | ||
| // OVS config. It will be provided for ovs-vswitchd service as other_config option | ||
| // +kubebuilder:default:={hw-offload: "true"} |
There was a problem hiding this comment.
Do we really want such a default at the API level?
If I understand correctly, this means that if a user sets ovsConfig = {"foo":"bar"}, then the default will not apply.
This may be confusing. Should we instead always add {hw-offload: "true"} to the ovsConfig value when it doesn't contain an explicit value for this field?
There was a problem hiding this comment.
I would like to keep default behaviour as is now. Always add {hw-offload: "true"} could be non-obvious for users, so I prefer user add this option if needed
|
Overall, the code looks good. Are the CI failures expected? |
I re-run |
Pull Request Test Coverage Report for Build 14443961186Details
💛 - Coveralls |
fa04774
into
Mellanox:network-operator-25.4.x
This is a backport k8snetworkplumbingwg#823. We need this one for an internal release until community approves a PR