Skip to content

fix: correct kargs.sh script path#66

Merged
e0ne merged 1 commit intoMellanox:network-operator-25.4.xfrom
e0ne:kargs-scipt-path
May 7, 2025
Merged

fix: correct kargs.sh script path#66
e0ne merged 1 commit intoMellanox:network-operator-25.4.xfrom
e0ne:kargs-scipt-path

Conversation

@e0ne
Copy link
Collaborator

@e0ne e0ne commented May 6, 2025

We can't relay on vars.UsingSystemdMode variable because we execute this from deamon even in a systemd mode.

We need to re-risit logic to not call this script twice

@github-actions
Copy link

github-actions bot commented May 6, 2025

Thanks for your PR,
To run vendors CIs, Maintainers can use one of:

  • /test-all: To run all tests for all vendors.
  • /test-e2e-all: To run all E2E tests for all vendors.
  • /test-e2e-nvidia-all: To run all E2E tests for NVIDIA vendor.

To skip the vendors CIs, Maintainers can use one of:

  • /skip-all: To skip all tests for all vendors.
  • /skip-e2e-all: To skip all E2E tests for all vendors.
  • /skip-e2e-nvidia-all: To skip all E2E tests for NVIDIA vendor.
    Best regards.

@e0ne e0ne force-pushed the kargs-scipt-path branch from f043afa to 684d722 Compare May 6, 2025 09:13
@coveralls
Copy link

coveralls commented May 6, 2025

Pull Request Test Coverage Report for Build 14857311476

Details

  • 4 of 4 (100.0%) changed or added relevant lines in 2 files are covered.
  • 8 unchanged lines in 2 files lost coverage.
  • Overall coverage increased (+0.006%) to 61.656%

Files with Coverage Reduction New Missed Lines %
controllers/drain_controller_helper.go 1 67.43%
controllers/sriovnetworknodepolicy_controller.go 7 61.49%
Totals Coverage Status
Change from base Build 14854067881: 0.006%
Covered Lines: 8601
Relevant Lines: 13950

💛 - Coveralls

@e0ne e0ne force-pushed the kargs-scipt-path branch from 684d722 to d11a487 Compare May 6, 2025 09:39
@e0ne e0ne marked this pull request as draft May 6, 2025 10:20
@e0ne e0ne force-pushed the kargs-scipt-path branch from d11a487 to 067b87e Compare May 6, 2025 10:23
We can't relay on vars.UsingSystemdMode variable because we execute
this from deamon even in a systemd mode.

We need to re-risit logic to not call this script twice

Signed-off-by: Ivan Kolodiazhnyi <ikolodiazhny@nvidia.com>
@e0ne e0ne force-pushed the kargs-scipt-path branch from 067b87e to 2f51236 Compare May 6, 2025 11:51
@e0ne e0ne marked this pull request as ready for review May 6, 2025 13:24
@e0ne e0ne merged commit a10f94b into Mellanox:network-operator-25.4.x May 7, 2025
9 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants