Skip to content

fix: use nvstaging in GA#70

Merged
rollandf merged 1 commit intoMellanox:network-operator-25.4.xfrom
rollandf:nvstaging
May 19, 2025
Merged

fix: use nvstaging in GA#70
rollandf merged 1 commit intoMellanox:network-operator-25.4.xfrom
rollandf:nvstaging

Conversation

@rollandf
Copy link
Member

No description provided.

@rollandf rollandf requested review from almaslennikov, e0ne and maze88 May 19, 2025 09:09
@github-actions
Copy link

Thanks for your PR,
To run vendors CIs, Maintainers can use one of:

  • /test-all: To run all tests for all vendors.
  • /test-e2e-all: To run all E2E tests for all vendors.
  • /test-e2e-nvidia-all: To run all E2E tests for NVIDIA vendor.

To skip the vendors CIs, Maintainers can use one of:

  • /skip-all: To skip all tests for all vendors.
  • /skip-e2e-all: To skip all E2E tests for all vendors.
  • /skip-e2e-nvidia-all: To skip all E2E tests for NVIDIA vendor.
    Best regards.

Copy link
Collaborator

@maze88 maze88 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code can be compressed a lot:

# ...
jobs:
  determine-docker-tag:
    runs-on: ubuntu-latest
    steps:
      - uses: actions/checkout@v4
        with:
          sparse-checkout: .
      - if: github.ref_type == 'branch'
        name: Determine tag (when git branch)
        run: |
          echo DOCKER_TAG=$(git rev-parse --short HEAD) | tee -a $GITHUB_ENV  # short git commit hash
      - if: github.ref_type == 'tag'
        name: Determine tag (when git tag)
        run: |
          echo DOCKER_TAG=${{ github.ref_name }} | tee -a $GITHUB_ENV
      - name: Store tag for following jobs
        id: store-docker-tag
        run: |
          echo DOCKER_TAG=$DOCKER_TAG >> $GITHUB_OUTPUT
    outputs:
      docker_tag: ${{ steps.store-docker-tag.outputs.DOCKER_TAG }}
  build-and-push-images:
    needs: determine-docker-registry-and-tag
    runs-on: ubuntu-latest
    env:
      BUILD_PLATFORMS: linux/amd64,linux/arm64,linux/ppc64le
      DOCKER_REGISTRY: nvcr.io/nvstaging/mellanox
      DOCKER_TAG: ${{ needs.determine-docker-registry-and-tag.outputs.docker_tag }}
# ...

@rollandf
Copy link
Member Author

Code can be compressed a lot, I will upload a suggestion in a moment...

This a temp fix for this release. No need for more changes.

@coveralls
Copy link

coveralls commented May 19, 2025

Pull Request Test Coverage Report for Build 15110249789

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 10 unchanged lines in 3 files lost coverage.
  • Overall coverage decreased (-0.06%) to 61.531%

Files with Coverage Reduction New Missed Lines %
controllers/helper.go 2 70.23%
controllers/sriovnetworknodepolicy_controller.go 3 60.89%
controllers/generic_network_controller.go 5 74.38%
Totals Coverage Status
Change from base Build 15014470111: -0.06%
Covered Lines: 8602
Relevant Lines: 13980

💛 - Coveralls

@rollandf
Copy link
Member Author

@maze88 updated as you requested.
A lot more changes, please review

Signed-off-by: Fred Rolland <frolland@nvidia.com>
@rollandf rollandf merged commit 4225daf into Mellanox:network-operator-25.4.x May 19, 2025
9 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants