Skip to content

Support node draining by external NVIDIA maintenance OP#84

Merged
heyvister1 merged 1 commit intoMellanox:network-operator-25.10.xfrom
heyvister1:disable-drain-controller
Oct 10, 2025
Merged

Support node draining by external NVIDIA maintenance OP#84
heyvister1 merged 1 commit intoMellanox:network-operator-25.10.xfrom
heyvister1:disable-drain-controller

Conversation

@heyvister1
Copy link
Collaborator

SRIOV OP internal drain controller can be disabled, through USE_MAINTENANCE_OPERATOR_DRAINER, and draining will be performed by external NVIDIA maintenance operator

Cherry-picked from upstream #952

…to enable/disable SRIOV OP drain controller, in favor of using maintenance OP to drive node drain aspects

Signed-off-by: Ido Heyvi <iheyvi@nvidia.com>
@github-actions github-actions bot added the docs label Oct 9, 2025
@github-actions
Copy link

github-actions bot commented Oct 9, 2025

Thanks for your PR,
To run vendors CIs, Maintainers can use one of:

  • /test-all: To run all tests for all vendors.
  • /test-e2e-all: To run all E2E tests for all vendors.
  • /test-e2e-nvidia-all: To run all E2E tests for NVIDIA vendor.

To skip the vendors CIs, Maintainers can use one of:

  • /skip-all: To skip all tests for all vendors.
  • /skip-e2e-all: To skip all E2E tests for all vendors.
  • /skip-e2e-nvidia-all: To skip all E2E tests for NVIDIA vendor.
    Best regards.

Copy link
Collaborator

@almaslennikov almaslennikov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, let's address the utests failure before merging

@coveralls
Copy link

Pull Request Test Coverage Report for Build 18373938486

Details

  • 4 of 4 (100.0%) changed or added relevant lines in 1 file are covered.
  • 4 unchanged lines in 1 file lost coverage.
  • Overall coverage increased (+0.1%) to 62.082%

Files with Coverage Reduction New Missed Lines %
controllers/helper.go 4 70.57%
Totals Coverage Status
Change from base Build 18361383049: 0.1%
Covered Lines: 8712
Relevant Lines: 14033

💛 - Coveralls

@rollandf
Copy link
Member

rollandf commented Oct 9, 2025

@heyvister1 do we push cherry-pick to master?

@heyvister1
Copy link
Collaborator Author

@heyvister1 do we push cherry-pick to master?

I didn't use git cherry-pick, rather than created a new PR for SRIOV under Mellanox org

@rollandf
Copy link
Member

rollandf commented Oct 9, 2025

@heyvister1 do we push cherry-pick to master?

I didn't use git cherry-pick, rather than created a new PR for SRIOV under Mellanox org

My question is more about to which branch we should push our PRs?

@heyvister1 heyvister1 changed the base branch from master to network-operator-25.10.x October 9, 2025 12:27
@heyvister1
Copy link
Collaborator Author

@heyvister1 do we push cherry-pick to master?

I didn't use git cherry-pick, rather than created a new PR for SRIOV under Mellanox org

My question is more about to which branch we should push our PRs?

Changed it to v25.10.x branch

@heyvister1
Copy link
Collaborator Author

heyvister1 commented Oct 9, 2025

/test-all

@nvidia-ci-cd nvidia-ci-cd force-pushed the network-operator-25.10.x branch from 26cdb99 to 17082ad Compare October 10, 2025 00:09
@heyvister1 heyvister1 merged commit baa4537 into Mellanox:network-operator-25.10.x Oct 10, 2025
20 of 25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants