feat: Use distroless images for Operator and Webhook#99
Merged
heyvister1 merged 1 commit intoMellanox:network-operator-25.10.xfrom Nov 4, 2025
Merged
feat: Use distroless images for Operator and Webhook#99heyvister1 merged 1 commit intoMellanox:network-operator-25.10.xfrom
heyvister1 merged 1 commit intoMellanox:network-operator-25.10.xfrom
Conversation
|
Thanks for your PR,
To skip the vendors CIs, Maintainers can use one of:
|
e0ne
changed the title
rollandf
reviewed
Nov 4, 2025
Dockerfile.webhook
Outdated
| RUN make _build-webhook BIN_PATH=build/_output/cmd | ||
|
|
||
| FROM quay.io/centos/centos:stream9 | ||
| FROM ${BASE_IMAGE_GO_DISTROLESS_DEV:-nvcr.io/nvidia/distroless/go:v3.2.1-dev} |
Member
There was a problem hiding this comment.
we should update only .nvidia Docker files
Collaborator
Author
There was a problem hiding this comment.
my bad, will fix it asap
rollandf
reviewed
Nov 4, 2025
| ARG BASE_IMAGE_GO_DISTROLESS_DEV | ||
|
|
||
| FROM golang:1.23 AS builder | ||
|
|
Member
There was a problem hiding this comment.
need:
line 27
FROM ${BASE_IMAGE_GO_DISTROLESS_DEV:-nvcr.io/nvidia/distroless/go:v3.2.1-dev}
Signed-off-by: Ivan Kolodiazhnyi <ikolodiazhny@nvidia.com>
heyvister1
approved these changes
Nov 4, 2025
heyvister1
merged commit 480823f
into
Mellanox:network-operator-25.10.x
10 of 12 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.